Skip to content

Fix "Add store details" task fails to mark as completed for selecting Nigeria based address #38181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 4 commits into from
May 10, 2023
Merged

Fix "Add store details" task fails to mark as completed for selecting Nigeria based address #38181

chihsuan merged 4 commits into from
May 10, 2023

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 9, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37451.

This PR updates the store details task completion logic only to check the post code field when it's not hidden.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install and activate WooCommerce in a brand new site
  2. Go to the WooCommerce onboarding wizard.
  • You can do this by installing and activating WooCommerce in a brand new site.
  • Or, via the WooCommerce ▸ Settings screen, locate the Help pulldown and re-run the wizard that way:

WooCommerce ▸ Settings screen > OBW

  1. Select a Nigeria-based address and fill out all store details fields
  2. Finish OBW.
  3. Go to WooCommerce > Home
  4. Observe that "Add store details" task is marked as completed.
  5. Go to WooCommmerce > Settings and Change store country to United State
  6. Go back to WooCommerce > Home
  7. Observe that "Add store details" task is not marked as completed.
  8. Click on "Add store details" task and fill out the post code field
  9. Go back to WooCommerce > Home
  10. Observe that "Add store details" task is marked as completed.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 9, 2023
@chihsuan chihsuan marked this pull request as ready for review May 9, 2023 04:27
@chihsuan chihsuan self-assigned this May 9, 2023
@chihsuan chihsuan requested review from a team, moon0326 and rjchow May 9, 2023 04:27
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Hi @moon0326, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Hi @moon0326, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023 •
edited
Loading

Test Results Summary

Commit SHA: b38a9aa

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1880010019820m 30s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

moon0326
moon0326 approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fix 👍 I like the logic.

LGTM and tested well 🚀

rjchow
rjchow approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! ✅

@chihsuan chihsuan merged commit fa658a0 into trunk May 10, 2023
@chihsuan chihsuan deleted the fix/37451-store-details-complete branch May 10, 2023 09:08
@github-actions github-actions bot added this to the 7.8.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@moon0326 moon0326 moon0326 approved these changes

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

[GlobalStep] "Add store details" task fails to mark as completed for selecting Nigeria based address while OBW.

4 participants

@chihsuan @moon0326 @rjchow