Skip to content

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented May 8, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Adds tinymce scripts so that the classic editor blocks work in the new product editing experience.

Screen Shot 2023-05-08 at 3 52 07 PM

Closes #38118 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Navigate to Tools -> WCA Test Helper -> Features and enable the new product blocks editing experience
  2. Navigate to Products -> Add new
  3. Click on the "Add description" button
  4. Add a classic editor block
  5. Check that the classic editor block works as expected without console errors

@joshuatf joshuatf requested a review from a team May 8, 2023 22:52
@joshuatf joshuatf self-assigned this May 8, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Test Results Summary

Commit SHA: c92bb93

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 54s
E2E Tests1880010019815m 6s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for adding this!

@louwie17 louwie17 merged commit 329fcd1 into trunk May 9, 2023
@louwie17 louwie17 deleted the add/38118 branch May 9, 2023 07:32
@github-actions github-actions bot added this to the 7.8.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Product Block Editor: FreeForm block not working - Tinymce error

3 participants