Skip to content

Add default styles for product meta in the TT3 order details table #38172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rrennick merged 2 commits into from
May 10, 2023
Merged

Add default styles for product meta in the TT3 order details table #38172

rrennick merged 2 commits into from
May 10, 2023

Conversation

@xristos3490
Copy link
Member

@xristos3490 xristos3490 commented May 8, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR aims to add default styles for product meta in TT3's order details tables.

Before:
Before
After:
After

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Ensure that we have a store running with TT3 theme.
  2. Add a variable product to the cart and proceed with the order.
  3. Notice the styling of the meta list being excessively default with the bullets.
  4. Apply this patch and refresh the thank-you page.
  5. Notice the item meta styling is fixed.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Test Results Summary

Commit SHA: 38db587

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 54s
E2E Tests1880010019817m 26s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #38172 (38db587) into trunk (5b3666b) will decrease coverage by 0.0%.
The diff coverage is 10.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #38172     +/-   ##
==========================================
- Coverage     51.2%    51.2%   -0.0%     
- Complexity   17417    17421      +4     
==========================================
  Files          440      440             
  Lines        80639    80640      +1     
==========================================
- Hits         41312    41310      -2     
- Misses       39327    39330      +3
Impacted Files Coverage Δ
...ocommerce/includes/abstracts/abstract-wc-order.php 76.4% <ø> (ø)
...ommerce/includes/abstracts/abstract-wc-product.php 88.3% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-addons.php 0.0% <ø> (ø)
...ocommerce/includes/admin/class-wc-admin-status.php 14.5% <ø> (ø)
.../includes/admin/helper/class-wc-helper-updater.php 28.9% <ø> (ø)
...erce/includes/admin/importers/mappings/default.php 4.5% <0.0%> (ø)
...udes/admin/settings/class-wc-settings-products.php 98.6% <ø> (ø)
...lugins/woocommerce/includes/class-wc-countries.php 95.4% <ø> (ø)
plugins/woocommerce/includes/class-wc-coupon.php 73.9% <ø> (ø)
...woocommerce/includes/class-wc-frontend-scripts.php 0.0% <ø> (ø)
... and 13 more

... and 1 file with indirect coverage changes

@xristos3490 xristos3490 requested review from a team and rrennick and removed request for a team May 8, 2023 20:00
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Hi @rrennick,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

rrennick
rrennick approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xristos3490 Thanks for the help.

@rrennick rrennick merged commit d93a5d4 into trunk May 10, 2023
@rrennick rrennick deleted the fix/tt3-order-details-item-meta-styling branch May 10, 2023 19:59
@github-actions github-actions bot added this to the 7.8.0 milestone May 10, 2023
@xristos3490 xristos3490 self-assigned this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rrennick rrennick rrennick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xristos3490 xristos3490

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@xristos3490 @rrennick