Add editor styles to product editor and iframe editor #38168
Conversation
|
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 4159528
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
louwie17
left a comment
louwie17
left a comment
There was a problem hiding this comment.
Nice work, this is testing well!
There are a couple lint errors and I left one inline comment.
Also I noticed one issue we will have to create a follow up for, the content-preview doesn't render any of the inline css, so if I set the layout to center it should add in-line css of display: flex; justifyContent: center, but it only adds that as html comments:
<!-- wp:buttons {"layout":{"type":"flex","justifyContent":"center"}} -->
Maybe there is an alternative serialize function for this?
| settings={ settings } | ||
| > | ||
| <EditorStyles styles={ settings?.styles } /> | ||
| {/* <EditorStyles styles={ styles } /> */} |
There was a problem hiding this comment.
This line can be removed right?
Good point. Will create another issue to address this. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Fixes an issue where certain editor styles (such as buttons) were not being applied to the editor and iframe editor.
Before
After
Closes #38021.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: