Skip to content

Fix spacing between pricing fields #38146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 3 commits into from
May 9, 2023
Merged

Fix spacing between pricing fields #38146

mdperez86 merged 3 commits into from
May 9, 2023

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented May 5, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38097

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Got to /wp-admin/tools.php?page=woocommerce-admin-test-helper
  2. Under Features tab make sure to enable product-block-editor
  3. Then visit /wp-admin/admin.php?page=wc-admin&path=/add-product
  4. Under Pricing tab and within Pricing section the spacing between the List price field and the Schedule sale should be as described in AkVNGImLgSqCObTQ3idVn7-fi-305-38548

@mdperez86 mdperez86 requested a review from a team May 5, 2023 16:30
@mdperez86 mdperez86 self-assigned this May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023 •
edited
Loading

Hi @joshuatf,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 706d10d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 50s
E2E Tests1880010019812m 37s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #38146 (6ef3507) into trunk (5b3666b) will increase coverage by 0.0%.
The diff coverage is 0.0%.

❗ Current head 6ef3507 differs from pull request most recent head 706d10d. Consider uploading reports for the commit 706d10d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             trunk   #38146   +/-   ##
========================================
  Coverage     51.2%    51.2%           
  Complexity   17417    17417           
========================================
  Files          440      440           
  Lines        80639    80635    -4     
========================================
- Hits         41312    41311    -1     
+ Misses       39327    39324    -3
Impacted Files Coverage Δ
...erce/includes/admin/importers/mappings/default.php 4.5% <0.0%> (ø)
...ugins/woocommerce/includes/class-wc-post-types.php 0.9% <0.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

joshuatf
joshuatf reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements! Looking great; just left one minor dimension change suggestion I'm seeing in the design.

packages/js/product-editor/src/blocks/schedule-sale/editor.scss Outdated
@@ -1,6 +1,18 @@
.wp-block-woocommerce-product-schedule-sale-fields {
.components-toggle-control {
margin-bottom: $gap-large;
Copy link
Contributor

@joshuatf joshuatf May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this as 32px in the design:

Screen Shot 2023-05-05 at 11 48 17 AM

@mdperez86 mdperez86 requested a review from joshuatf May 9, 2023 15:45
joshuatf
joshuatf approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, Maikel! This LGTM!

@mdperez86 mdperez86 merged commit 2276953 into trunk May 9, 2023
@mdperez86 mdperez86 deleted the add/38097 branch May 9, 2023 23:13
@github-actions github-actions bot added this to the 7.8.0 milestone May 9, 2023
@rodelgc
Copy link
Contributor

rodelgc commented Jun 1, 2023

Uploading expected design
rlLzUUNHuU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joshuatf joshuatf joshuatf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdperez86 mdperez86

Labels

None yet

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Product Block Editor: Pricing section has inconsistent spacing between fields

4 participants

@mdperez86 @rodelgc @joshuatf