Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 5, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #36925.

The automated tax screen is only visible when all store details (address, zip code, city) are filled in. However, these fields are not mandatory in the first step.

Thus, when a user connects the Jetpack/WCS without filling in all fields, the user is redirected to the first step without any error message.

This PR makes all fields mandatory to fix the issue.

p1677138140476049/1676907287.360079-slack-C01SFMVEYAK

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install and activate WooCommerce in a brand new site
  2. Go to the WooCommerce onboarding wizard.
  3. Choose US as store country on the store details step
  4. Click on the Continue button without filling out other fields
  5. Go to WooCommerce > Home and click on Add tax rates task from Task list
  6. Click on the Continue button
  7. Observe that it displays form validation error messages

Screenshot 2023-05-05 at 18 42 22

  1. Fill out all fields
  2. Click on the Continue button
  3. Should go to next step

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 5, 2023
@chihsuan chihsuan marked this pull request as ready for review May 5, 2023 10:45
@chihsuan chihsuan requested review from a team, ilyasfoo and rjchow May 5, 2023 10:46
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Test Results Summary

Commit SHA: 1d40832

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1870010019718m 6s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed! Nice work!

@chihsuan chihsuan self-assigned this May 8, 2023
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! 🚢

@chihsuan chihsuan merged commit 0148c3e into trunk May 9, 2023
@chihsuan chihsuan deleted the update/tax-location-form branch May 9, 2023 09:01
@github-actions github-actions bot added this to the 7.8.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The enable automated tax screen is not displayed after connecting Jetpack and WCS

4 participants