Skip to content

Fix wc-experimental strings are not translated #38108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 2 commits into from
May 9, 2023
Merged

Fix wc-experimental strings are not translated #38108

chihsuan merged 2 commits into from
May 9, 2023

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 4, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37416.

Add wc-experimental to $translated_scripts to load i18n locale data for wc-experimental.

How to test the changes in this Pull Request:

  1. Set the WP administration language to Italian.
  2. Go to /wp-admin/update-core.php and make sure the translations are all up to date
  3. Go to WooCommerce > Home
  4. Scroll down and confirm the inbox note "Dismiss" button is translated to Ignora.

Screenshot 2023-05-04 at 13 33 37

@chihsuan chihsuan marked this pull request as ready for review May 4, 2023 05:34
@chihsuan chihsuan self-assigned this May 4, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 4, 2023
@chihsuan chihsuan requested review from a team, ilyasfoo and moon0326 May 4, 2023 05:34
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hi @ilyasfoo, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hi @ilyasfoo, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Test Results Summary

Commit SHA: d584ccc

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 55s
E2E Tests1870010019715m 33s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #38108 (d584ccc) into trunk (fa6ee94) will decrease coverage by 0.0%.
The diff coverage is 2.6%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #38108     +/-   ##
==========================================
- Coverage     51.3%    51.2%   -0.0%     
- Complexity   17409    17417      +8     
==========================================
  Files          440      440             
  Lines        80584    80639     +55     
==========================================
- Hits         41311    41310      -1     
- Misses       39273    39329     +56
Impacted Files Coverage Δ
...ugins/woocommerce/includes/class-wc-post-types.php 0.9% <0.0%> (-<0.1%) ⬇️
...merce/includes/emails/class-wc-email-new-order.php 62.4% <0.0%> (-1.0%) ⬇️
...ins/woocommerce/includes/emails/class-wc-email.php 53.1% <ø> (ø)
...ludes/tracks/events/class-wc-products-tracking.php 0.0% <0.0%> (ø)
plugins/woocommerce/includes/class-wc-cart.php 79.4% <50.0%> (-0.1%) ⬇️
...ocommerce/includes/abstracts/abstract-wc-order.php 76.4% <100.0%> (ø)

... and 1 file with indirect coverage changes

@DAnn2012 DAnn2012 mentioned this pull request May 4, 2023
Closed
5 tasks
ilyasfoo
ilyasfoo approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM!

@chihsuan
Copy link
Member Author

chihsuan commented May 9, 2023

I am going to merge this with one approval since this is a small change.

@chihsuan chihsuan merged commit e06097b into trunk May 9, 2023
@chihsuan chihsuan deleted the fix/wc-experimental-i18n branch May 9, 2023 09:07
@github-actions github-actions bot added this to the 7.8.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moon0326 moon0326 Awaiting requested review from moon0326

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

The z-index of the WC top header is too high and a couple of strings are not translated

3 participants

@chihsuan @ilyasfoo