Skip to content

Restoring standard tabbing behavior in product block editor #38105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joelclimbsthings merged 2 commits into from
May 5, 2023
Merged

Restoring standard tabbing behavior in product block editor #38105

joelclimbsthings merged 2 commits into from
May 5, 2023

Conversation

@joelclimbsthings
Copy link
Contributor

@joelclimbsthings joelclimbsthings commented May 3, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Previous to this PR tabbing behavior was not working in the product editor form (see issue video). After some exploration I realized that the WritingFlow component was responsible. It's used for selection across blocks which I don't believe is needed for our implementation, so it's been removed.

Closes #37932 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Checkout branch and enable the product-block-editor feature flag via the WCA Test Helper plugin.
  2. Navigate to Products -> Add new on the sidebar.
  3. Use the tab key to navigate through the form fields in the editor. I should focus the fields as normal.

@joelclimbsthings joelclimbsthings force-pushed the fix/tabbed-navigation-37932 branch from 453bbf9 to 97d3b13 Compare May 3, 2023 23:15
@joelclimbsthings joelclimbsthings changed the title Removing WritingFlow wrapper which was suppressing tab behavior Restoring standard tabbing behavior in product block editor May 3, 2023
@joelclimbsthings joelclimbsthings requested a review from a team May 3, 2023 23:19
@joelclimbsthings joelclimbsthings self-assigned this May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@joelclimbsthings joelclimbsthings marked this pull request as ready for review May 3, 2023 23:19
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Test Results Summary

Commit SHA: 97d3b13

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 50s
E2E Tests1870010019717m 20s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@joelclimbsthings joelclimbsthings linked an issue May 5, 2023 that may be closed by this pull request
Product Block Editor: Hitting escape seems to select and highlight parent blocks #38062
Closed
3 tasks
joshuatf
joshuatf approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, @joelclimbsthings! This is testing well for me and I agree that we don't have a need for this at the moment.

Out of curiosity did you ever find the specific area of this component that handles this? I'm wondering if a block wants to implement this if they can wrap with WritingFlow to get the intended behavior in those cases.

@joshuatf joshuatf mentioned this pull request May 5, 2023
Closed
3 tasks
@joelclimbsthings
Copy link
Contributor Author

joelclimbsthings commented May 5, 2023

Thanks for the review @joshuatf ! I admittedly didn't dig in too deep, but saw that it was handling a lot of key events with the intention of capturing the intention to select multiple blocks. I'd imagine that it wouldn't be too difficult to figure it out from there, in the case that we want to implement on the in-editor editors 😅

@joelclimbsthings joelclimbsthings merged commit e7d6771 into trunk May 5, 2023
@joelclimbsthings joelclimbsthings deleted the fix/tabbed-navigation-37932 branch May 5, 2023 19:39
@github-actions github-actions bot added this to the 7.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joshuatf joshuatf joshuatf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joelclimbsthings joelclimbsthings

Labels

None yet

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Product Block Editor: Hitting escape seems to select and highlight parent blocks Product Block Editor: Fix tab navigation

3 participants

@joelclimbsthings @joshuatf