Skip to content

Use snackbar to show variations generated message, instead of browser alert #38103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattsherman merged 2 commits into from
May 4, 2023
Merged

Use snackbar to show variations generated message, instead of browser alert #38103

mattsherman merged 2 commits into from
May 4, 2023

Conversation

@mattsherman
Copy link
Contributor

@mattsherman mattsherman commented May 3, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Before

Screenshot 2023-05-03 at 18 11 08

After

Screenshot 2023-05-03 at 18 09 49

Closes #38095 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Products > Add New
  2. Change product type to Variable
  3. Add attributes marked as Used for variations
  4. Click Generate variations on Variations tab
  5. Verify snackbar notice is shown and dismisses automatically after a short delay

@mattsherman mattsherman self-assigned this May 3, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Test Results Summary

Commit SHA: 613fce7

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 54s
E2E Tests1870010019715m 53s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@mattsherman mattsherman marked this pull request as ready for review May 3, 2023 22:31
@mattsherman mattsherman requested a review from a team May 3, 2023 22:31
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited
Loading

Hi @octaedro,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@octaedro octaedro requested review from octaedro and removed request for a team May 4, 2023 14:45
octaedro
octaedro approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @mattsherman! This is testing well here and the code LGTM :shipit:

@mattsherman mattsherman merged commit 79377fb into trunk May 4, 2023
@mattsherman mattsherman deleted the update/generated-variations-snackbar branch May 4, 2023 17:05
@github-actions github-actions bot added this to the 7.8.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@octaedro octaedro octaedro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattsherman mattsherman

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Use snackbar to show variations generated message, instead of browser alert

3 participants

@mattsherman @octaedro