Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented May 3, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37752.

Payfast has gone through a rebranding that updates their logo and also a name change from “PayFast” to “Payfast”.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to WooCommmerce > Settings and Change store country to South Africa
  2. Go to WooCommerce > Settings > Advanced > WooCommerce.com (/wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com)
  3. Uncheck Display suggestions within WooCommerce option
  4. Go to WooCommerce > Home and click on Set up payments task from Task list
  5. Observe that the payfast name and logo are shown as below

Screenshot 2023-05-03 at 16 38 17

@github-actions github-actions bot added focus: react admin [team:Ghidorah] package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 3, 2023
@chihsuan chihsuan marked this pull request as ready for review May 3, 2023 08:40
@chihsuan chihsuan self-assigned this May 3, 2023
@chihsuan chihsuan requested review from a team, ilyasfoo and moon0326 May 3, 2023 08:43
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Hi @ilyasfoo, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Test Results Summary

Commit SHA: 3389690

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1870010019713m 38s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@crunnells crunnells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM!

@chihsuan chihsuan merged commit ef7bf6a into trunk May 5, 2023
@chihsuan chihsuan deleted the update/payfast branch May 5, 2023 07:42
@github-actions github-actions bot added this to the 7.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Payfast's title and logo in OBW payment task

4 participants