Skip to content

Fix partial data import with product task imports #38089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilyasfoo merged 3 commits into from
May 4, 2023
Merged

Fix partial data import with product task imports #38089

ilyasfoo merged 3 commits into from
May 4, 2023

Conversation

@ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented May 3, 2023

Changes proposed in this Pull Request:

Closes #38069.

Fixes import failures when user profile language preference is set to en_US.

How to test the changes in this Pull Request:

Prerequisite

  1. Go to Users > Profile
  2. Set language to English (United States)
  3. Save profile

Testing product type

  1. Go to WooCommerce > Home
  2. Click on "Add Products" task
  3. Click on "Variable product"
  4. Observe the product is created as a "variable product" and the product image is shown

Testing sample import

  1. Go to WooCommerce > Home
  2. Click on "Add Products" task
  3. Click on "View more product types"
  4. Click on "Load Sample Products"
  5. Observe 9 sample products are loaded and product image is shown for the newly imported products

@ilyasfoo ilyasfoo requested review from a team, chihsuan and rjchow May 3, 2023 08:18
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Hi @chihsuan, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Test Results Summary

Commit SHA: 8a13c87

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 53s
E2E Tests1870010019714m 44s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@ilyasfoo ilyasfoo added this to the 7.8.0 milestone May 3, 2023
chihsuan
chihsuan approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested well! 🚢

Thanks for adding the tests. 😃

rjchow
rjchow approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well and fixes the issue! Can't say I understand what's going on though - what are mappings and why are they 0 sometimes and not other times?

@ilyasfoo
Copy link
Contributor Author

ilyasfoo commented May 4, 2023

Good question, @rjchow! It's because there's this logic called by our product task import which would fail when user profile locale is en_US.

I think having translated column names in export/import is not a good design, but I digress.

@ilyasfoo ilyasfoo merged commit 8e6fd41 into trunk May 4, 2023
@ilyasfoo ilyasfoo deleted the fix/38069-fix-product-task-imports branch May 4, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

+1 more reviewer

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Setting user locale to en_US breaking product task import

4 participants

@ilyasfoo @chihsuan @rjchow