Skip to content

Prevent double debouncing of iframe editor callback #38087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuatf merged 2 commits into from
May 5, 2023
Merged

Prevent double debouncing of iframe editor callback #38087

joshuatf merged 2 commits into from
May 5, 2023

Conversation

@joshuatf
Copy link
Contributor

@joshuatf joshuatf commented May 3, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38020 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Navigate to Tools -> WCA Test Helper -> Features and enable the new product blocks editing experience
  2. Navigate to Products -> Add new
  3. Click on Add description
  4. Add some content
  5. Wait approximately ~2s
  6. Close the modal
  7. Make sure the content shows in the preview or click "Edit description" to make sure the content has persisted

@joshuatf joshuatf requested a review from a team May 3, 2023 01:32
@joshuatf joshuatf self-assigned this May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Test Results Summary

Commit SHA: a65b89c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202691m 2s
E2E Tests1870010019712m 30s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it tested well, although is this a temporary fix?

@joshuatf
Copy link
Contributor Author

joshuatf commented May 5, 2023

Approving this as it tested well, although is this a temporary fix?

We don't need to add further debouncing, but we made to add a check that all changes have been applied once buttons are in place in the modal.

@joshuatf joshuatf merged commit 14ed88c into trunk May 5, 2023
@joshuatf joshuatf deleted the fix/38020 branch May 5, 2023 16:15
@github-actions github-actions bot added this to the 7.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@joshuatf joshuatf

Labels

None yet

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Iframe Editor: incomplete content on modal close

3 participants

@joshuatf @louwie17