Skip to content

Conversation

@aezazs-multidots
Copy link
Contributor

@aezazs-multidots aezazs-multidots commented May 2, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38068.

How to test the changes in this Pull Request:

Review changes should be sufficient.

@woocommercebot woocommercebot requested review from a team, barryhughes, ilyasfoo and moon0326 and removed request for a team May 2, 2023 09:45
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Significance: patch
Type: update


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aezazs-multidots Could you please add a changelog message here? 🙏

@barryhughes barryhughes removed their request for review May 3, 2023 18:45
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @aezazs-multidots! LGTM

@ilyasfoo ilyasfoo merged commit 24a59c8 into woocommerce:trunk May 5, 2023
@github-actions github-actions bot added this to the 7.8.0 milestone May 5, 2023
@rodelgc
Copy link
Contributor

rodelgc commented May 24, 2023

Steps to test:

  1. Start with a fresh install of WooCommerce
  2. Skip onboarding wizard.
  3. Go to WooCommerce > Home
  4. Click "Add Products" from the home task list.
  5. Click "Physical product".
  6. Tour message for "Product name" field appears, as expected. Click "Next".
  7. Tour message for the "Product description" field appears.
  8. Verify that the tour message does not show the text Start typing your new product name here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extraneous text in new product spotlight

4 participants