Add fixed toolbar to modal editor #38031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Contributor
Test Results SummaryCommit SHA: 07b8417
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
joshuatf
force-pushed
the
add/37911
branch
2 times, most recently
from
89b1a22 to
fc93859
Compare
joelclimbsthings
approved these changes
May 1, 2023
Contributor
joelclimbsthings
left a comment
joelclimbsthings
left a comment
There was a problem hiding this comment.
Looks great @joshuatf , working well on my end. I noticed that the layout breaks in a few different ways on mobile, but my understanding is that we're not worrying about such things at this point. 
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38031 +/- ##
==========================================
- Coverage 51.5% 51.3% -0.2%
- Complexity 17281 17409 +128
==========================================
Files 430 440 +10
Lines 80033 80584 +551
==========================================
+ Hits 41217 41311 +94
- Misses 38816 39273 +457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Moves the contextual toolbar to a fixed position under the modal header.
Closes #37899 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: