Skip to content

Remove strange block editor highlighting within product block editor #38000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 2 commits into from
Apr 28, 2023
Merged

Remove strange block editor highlighting within product block editor #38000

louwie17 merged 2 commits into from
Apr 28, 2023

Conversation

@louwie17
Copy link
Contributor

@louwie17 louwie17 commented Apr 26, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This removes the highlighting when selecting block content or the highlight within tab buttons.

Closes #37928

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Load this branch and enable the product-block-editor feature flag
  2. Go to Products > Add New click on the content of individual blocks, like the description or labels of fields, there should be no blue outline around the entire block.
  3. Now switch tabs, the tab button should only show a blue border at the bottom not around the entire button.
  4. Play around with the summary field and the edit description field, these should still work and act the same (not missing any specific highlighting).

@louwie17 louwie17 requested a review from a team April 26, 2023 09:54
@louwie17 louwie17 added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: product management [team:Mothra] labels Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 871876e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 50s
E2E Tests1870010019719m 16s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mdperez86
mdperez86 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@mdperez86 mdperez86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job @louwie17

@louwie17 louwie17 merged commit 452fa75 into trunk Apr 28, 2023
@louwie17 louwie17 deleted the fix/37928_block_editor_highlighting branch April 28, 2023 11:31
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 28, 2023
lanej0 pushed a commit that referenced this pull request May 1, 2023
@louwie17
Remove strange block editor highlighting within product block editor (#…
623a407 
…38000)

* Remove or hide block highlighting within product block editor

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdperez86 mdperez86 mdperez86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@louwie17 louwie17

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Product Block Editor: Remove weird highlighting when clicking on un editable content blocks

3 participants

@louwie17 @mdperez86