Skip to content

Remove AUTO-DRAFT in product name field on create new product page #37982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdperez86 merged 3 commits into from
Apr 28, 2023
Merged

Remove AUTO-DRAFT in product name field on create new product page #37982

mdperez86 merged 3 commits into from
Apr 28, 2023

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Apr 25, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37930

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Got to /wp-admin/tools.php?page=woocommerce-admin-test-helper
  2. Under Features tab make sure to enable product-block-editor
  3. Then visit /wp-admin/admin.php?page=wc-admin&path=/add-product
  4. Under General tab and within Basic details section the product name should not longer be AUTO-DRAFT when creating the product.

@mdperez86 mdperez86 requested a review from a team April 25, 2023 14:36
@mdperez86 mdperez86 self-assigned this Apr 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023 •
edited
Loading

Hi @louwie17,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #37982 (7e3f5a6) into trunk (7a63646) will decrease coverage by 0.2%.
The diff coverage is 14.5%.

❗ Current head 7e3f5a6 differs from pull request most recent head 1b453eb. Consider uploading reports for the commit 1b453eb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             trunk   #37982     +/-   ##
==========================================
- Coverage     51.5%    51.3%   -0.2%     
- Complexity   17281    17409    +128     
==========================================
  Files          430      440     +10     
  Lines        80030    80561    +531     
==========================================
+ Hits         41215    41295     +80     
- Misses       38815    39266    +451
Impacted Files Coverage Δ
...mmerce/includes/admin/class-wc-admin-importers.php 0.0% <0.0%> (ø)
...merce/includes/admin/class-wc-admin-post-types.php 9.5% <0.0%> (ø)
...rters/class-wc-product-csv-importer-controller.php 35.3% <0.0%> (-0.1%) ⬇️
...ugins/woocommerce/includes/class-wc-post-types.php 1.0% <0.0%> (-0.1%) ⬇️
...ludes/tracks/events/class-wc-importer-tracking.php 0.0% <0.0%> (ø)
...ludes/wccom-site/class-wc-wccom-site-installer.php 0.0% <0.0%> (ø)
...ation/class-wc-wccom-site-installation-manager.php 0.0% <0.0%> (ø)
...class-wc-wccom-site-installation-state-storage.php 0.0% <0.0%> (ø)
...llation/class-wc-wccom-site-installation-state.php 0.0% <0.0%> (ø)
...-wccom-site-installation-step-activate-product.php 0.0% <0.0%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 1b453eb

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202690m 54s
E2E Tests1870010019721m 0s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

louwie17
louwie17 requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, and code looks good, just looks like you added or left an unnecessary import useEffect (see inline comment).

packages/js/product-editor/src/blocks/name/edit.tsx Outdated
Fragment,
createInterpolateElement,
useState,
useEffect,
Copy link
Contributor

@louwie17 louwie17 Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary import?

Copy link
Contributor Author

@mdperez86 mdperez86 Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louwie17. Done -> 1b453eb

@mdperez86 mdperez86 requested a review from louwie17 April 28, 2023 14:54
louwie17
louwie17 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mdperez86 mdperez86 merged commit 1514333 into trunk Apr 28, 2023
@mdperez86 mdperez86 deleted the add/37930 branch April 28, 2023 15:33
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 28, 2023
lanej0 pushed a commit that referenced this pull request May 1, 2023
@mdperez86
Remove AUTO-DRAFT in product name field on create new product page (#…
155c415 
…37982)

* Remove AUTO-DRAFT in product name field on create new product page #37930

* Add changelog file

* Remove non needed useEffect import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louwie17 louwie17 louwie17 approved these changes

Assignees

@mdperez86 mdperez86

Labels

None yet

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Product Block Editor: Remove AUTO-DRAFT in product name field on create new product page

3 participants

@mdperez86 @louwie17