Working add shipping class option and modal #37968

joelclimbsthings · 2023-04-25T00:13:50Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Adding "create new shipping class" option in Shipping class dropdown on product block editor, as well as modal.

Closes #37886 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Checkout branch and enable product-block-editor feature flag with the WCA Test Helper plugin.
Navigate to Products -> Add new, and you should see the product block editor.
Navigate to Shipping tab, and select "Follow class" under "Shipping fee" heading.
This should reveal a drop-down menu with a list of any shipping classes.
Click "Add new shipping class" within the drop-down, which should reveal the shipping class modal.
Fill out the modal form with a shipping class and hit "Add"
This should add the shipping class and select it within the drop-down.
Save the product, and refresh to ensure the value persists.

github-actions · 2023-04-25T00:44:37Z

Test Results Summary

Commit SHA: 442b974

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	267	0	0	2	0	269	0m 52s
E2E Tests	187	0	0	10	0	197	17m 57s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

codecov · 2023-04-25T00:49:15Z

Codecov Report

Merging #37968 (fff60ec) into trunk (7a63646) will decrease coverage by 0.2%.
The diff coverage is 14.3%.

❗ Current head fff60ec differs from pull request most recent head 442b974. Consider uploading reports for the commit 442b974 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             trunk   #37968     +/-   ##
==========================================
- Coverage     51.5%    51.2%   -0.2%     
- Complexity   17281    17409    +128     
==========================================
  Files          430      440     +10     
  Lines        80030    80576    +546     
==========================================
+ Hits         41215    41295     +80     
- Misses       38815    39281    +466

Impacted Files	Coverage Δ
...mmerce/includes/admin/class-wc-admin-importers.php	`0.0% <0.0%> (ø)`
...merce/includes/admin/class-wc-admin-post-types.php	`9.5% <0.0%> (ø)`
...rters/class-wc-product-csv-importer-controller.php	`35.3% <0.0%> (-0.1%)`	⬇️
...ugins/woocommerce/includes/class-wc-post-types.php	`1.0% <0.0%> (-0.1%)`	⬇️
...ludes/tracks/events/class-wc-importer-tracking.php	`0.0% <0.0%> (ø)`
...ludes/wccom-site/class-wc-wccom-site-installer.php	`0.0% <0.0%> (ø)`
...ation/class-wc-wccom-site-installation-manager.php	`0.0% <0.0%> (ø)`
...class-wc-wccom-site-installation-state-storage.php	`0.0% <0.0%> (ø)`
...llation/class-wc-wccom-site-installation-state.php	`0.0% <0.0%> (ø)`
...-wccom-site-installation-step-activate-product.php	`0.0% <0.0%> (ø)`
... and 16 more

... and 1 file with indirect coverage changes

louwie17

Nice work @joelclimbsthings, this tested well! Although I did encounter a strange problem with the No shipping class option, where it auto selected the free shipping after selecting that.
I assume this was slightly un-expected behaviour after adding the No shipping class option? This could be addressed in a follow up, it seemed like the rest tested fine.

louwie17 · 2023-04-28T14:58:46Z

packages/js/product-editor/src/blocks/shipping-fee/edit.tsx

 const FREE_SHIPPING_OPTION_VALUE = 'free_shipping';

+export const DEFAULT_SHIPPING_CLASS_OPTIONS: SelectControl.Option[] = [
+	{ value: '', label: __( 'No shipping class', 'woocommerce' ) },


It seems like when we select this now, the Free Shipping button gets auto selected. Is this what we decided on?
It feels kinda strange, maybe we want to update that useEffect on line 174 to fix this.

joelclimbsthings · 2023-04-28T17:11:45Z

Thanks for the review @louwie17 . When I saw that behavior I made the assumption that it was expected since it's an invalid state, but on second though it is odd, so I've removed it in 68016b8.

I also had to rebase, but that's the extent of the changes. Let me know what you think.

github-actions · 2023-04-28T17:12:23Z

Hi @louwie17, @joshuatf,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

joshuatf

Code looks good to me. Left one comment about a translatable string and then same question as @louwie17 on the behavior.

.../product-editor/src/components/add-new-shipping-class-modal/add-new-shipping-class-modal.tsx

joelclimbsthings · 2023-04-28T22:03:51Z

Thanks @joshuatf , I believe I'd already removed that behavior in 68016b8 as mentioned here. Was there something different happening?

louwie17

This tested well this time around, nice work @joelclimbsthings 👍

I did notice that No shipping class is shown as an invalid option, disabling the form:

This is not a blocker for me in this PR, but curious if that was the expected behaviour we intended? cc: @jarekmorawski

joelclimbsthings · 2023-05-01T17:04:24Z

Thanks @louwie17 , I assumed this was correct when "follow class" selected under shipping fee, since it wouldn't make sense if no shipping class is selected. Definitely up to change via a follow-up pending @jarekmorawski 's thoughts!

rodelgc · 2023-05-29T07:57:52Z

Updated testing instructions for this PR:

Checkout branch and enable product-block-editor feature flag with the WCA Test Helper plugin.
Navigate to Products -> Add new, and you should see the product block editor.
Navigate to Shipping tab, and click on the "Shipping class" menu.
This should reveal a drop-down menu with a list of any shipping classes.
Click "Add new shipping class" within the drop-down, which should reveal the shipping class modal.
Fill out the modal form with a shipping class and hit "Add"
This should add the shipping class and select it within the drop-down.
Save the product, and refresh to ensure the value persists.

joelclimbsthings self-assigned this Apr 25, 2023

github-actions bot added the focus: react admin [team:Ghidorah] label Apr 25, 2023

joelclimbsthings requested a review from a team April 25, 2023 19:50

joelclimbsthings marked this pull request as ready for review April 25, 2023 19:50

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 25, 2023

joelclimbsthings force-pushed the add/shipping-class-creation-37886 branch from fd52b8b to 1412686 Compare April 25, 2023 21:14

louwie17 previously approved these changes Apr 28, 2023

View reviewed changes

joelclimbsthings dismissed louwie17’s stale review via 6a36360 April 28, 2023 17:05

joelclimbsthings added 6 commits April 28, 2023 10:06

Working add shipping class option and modal

0073239

Removing console statement

91a880f

Adding changelogs

7127502

Removing interpolate component dep

b7b3767

Updatring pnpm lock file...again

35ceedc

Removing auto selection of radio when no class selected

68016b8

joelclimbsthings force-pushed the add/shipping-class-creation-37886 branch from 6a36360 to 68016b8 Compare April 28, 2023 17:10

joelclimbsthings requested a review from louwie17 April 28, 2023 17:12

joshuatf reviewed Apr 28, 2023

View reviewed changes

.../product-editor/src/components/add-new-shipping-class-modal/add-new-shipping-class-modal.tsx Outdated Show resolved Hide resolved

Making Name string translatable

442b974

joelclimbsthings requested a review from joshuatf April 28, 2023 22:03

louwie17 approved these changes May 1, 2023

View reviewed changes

joelclimbsthings merged commit 16b9191 into trunk May 1, 2023

joelclimbsthings deleted the add/shipping-class-creation-37886 branch May 1, 2023 17:04

github-actions bot added this to the 7.8.0 milestone May 1, 2023

lanej0 pushed a commit that referenced this pull request May 1, 2023

Adding shipping class option and modal (#37968)

c7b63a2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Working add shipping class option and modal #37968

Working add shipping class option and modal #37968

Uh oh!

joelclimbsthings commented Apr 25, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Apr 25, 2023 •

edited

Loading

Uh oh!

codecov bot commented Apr 25, 2023 •

edited

Loading

Uh oh!

louwie17 left a comment

Uh oh!

louwie17 Apr 28, 2023

Uh oh!

joelclimbsthings commented Apr 28, 2023

Uh oh!

github-actions bot commented Apr 28, 2023 •

edited

Loading

Uh oh!

joshuatf left a comment

Uh oh!

Uh oh!

joelclimbsthings commented Apr 28, 2023

Uh oh!

louwie17 left a comment

Uh oh!

joelclimbsthings commented May 1, 2023

Uh oh!

rodelgc commented May 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Working add shipping class option and modal #37968

Working add shipping class option and modal #37968

Uh oh!

Conversation

joelclimbsthings commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Uh oh!

github-actions bot commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

codecov bot commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

louwie17 left a comment

Choose a reason for hiding this comment

Uh oh!

louwie17 Apr 28, 2023

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings commented Apr 28, 2023

Uh oh!

github-actions bot commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshuatf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joelclimbsthings commented Apr 28, 2023

Uh oh!

louwie17 left a comment

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings commented May 1, 2023

Uh oh!

rodelgc commented May 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joelclimbsthings commented Apr 25, 2023 •

edited

Loading

github-actions bot commented Apr 25, 2023 •

edited

Loading

codecov bot commented Apr 25, 2023 •

edited

Loading

github-actions bot commented Apr 28, 2023 •

edited

Loading