Track stock quantity for this product should be disabled when Enable stock management within settings is disabled, and enabled otherwise #37957
Conversation
…stock management within settings is disabled, and enabled otherwise.
github-actions
bot
added
the
plugin: woocommerce
|
Hi , @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
joshuatf
left a comment
joshuatf
left a comment
There was a problem hiding this comment.
Nice addition with the disabled prop for the toggle block! Testing well and LGTM!
Left one comment just thinking out loud about how we use this in the future, butI think we can address this when we get there.
| "property": { | ||
| "type": "string" | ||
| }, | ||
| "disabled": { |
| array( | ||
| 'label' => __( 'Track stock quantity for this product', 'woocommerce' ), | ||
| 'property' => 'manage_stock', | ||
| 'disabled' => 'yes' !== get_option( 'woocommerce_manage_stock' ), |
There was a problem hiding this comment.
Just thinking about this in the future: once the settings screens are Reactified, we might want the ability to either:
a. Refetch this template (so we have the correct disabled property) OR
b. Move this setting check to the frontend
But this issue doesn't exist for the time being and I think punting it down the road is fine.
Test Results SummaryCommit SHA: a776c64
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #37888
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=woocommerce-admin-test-helperproduct-block-editorManage stockis active under/wp-admin/admin.php?page=wc-settings&tab=products§ion=inventorythenTrack stock quantity for this productunder/wp-admin/admin.php?page=wc-admin&path=/add-product&tab=inventoryshould be enabledManage stockis not active under/wp-admin/admin.php?page=wc-settings&tab=products§ion=inventorythenTrack stock quantity for this productunder/wp-admin/admin.php?page=wc-admin&path=/add-product&tab=inventoryshould be disabled