Adding Stock status to inventory tab and toggle block #37906

joelclimbsthings · 2023-04-20T20:11:57Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Adds stock status to product block editor inventory section.

I also ended up refactoring a previous inventory fields block and adding a generic toggle block.

Closes #37884 .

How to test the changes in this Pull Request:

Checkout branch and enable product-block-editor feature flag using WCA Test Helper.
Navigate to Products -> Add new to see new product block editor.
Add a name to the product.
Go to Inventory tab.
With "track stock quantity" toggle disabled, you should see the "Stock status" radio field.
Select a different option, refresh, and ensure that your selection persists.
Enable the "track stock status" toggle above.
The "Stock status" radio should disappear and now display the "available quantity" field.
Ensure values for both of those fields also persist when saving and refreshing.

github-actions · 2023-04-20T20:15:53Z

Test Results Summary

Commit SHA: 2e4d857

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	267	0	0	2	0	269	0m 52s
E2E Tests	187	0	0	10	0	197	15m 21s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

github-actions · 2023-04-20T20:26:11Z

Hi @mdperez86,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

mdperez86

Nice job here @joelclimbsthings I just left 2 comments about the block naming convention.

packages/js/product-editor/src/blocks/inventory-quantity/block.json

packages/js/product-editor/src/blocks/toggle/block.json

joelclimbsthings · 2023-04-21T16:35:28Z

Thanks @mdperez86 , good call! I've remedied the block names in 41c7227.

mdperez86

LGTM @joelclimbsthings !!
This PR needs a rebase. Ping me when ready to go.

mdperez86

Nice job here @joelclimbsthings

mdperez86

Yep, we always forget server side registration.
You mentioned in my PR so don't forget to add new blocks in the server side too.
https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Admin/Features/ProductBlockEditor/BlockRegistry.php#L22

mdperez86 · 2023-04-21T21:08:55Z

packages/js/product-editor/src/blocks/inventory-quantity/block.json

 	"apiVersion": 2,
-	"name": "woocommerce/product-track-inventory-fields",
-	"title": "Product track inventory fields",
+	"name": "woocommerce/product-inventory-quantity-field",


You forgot to change this also in https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Admin/Features/ProductBlockEditor/BlockRegistry.php#L39

mdperez86 · 2023-04-21T21:09:50Z

packages/js/product-editor/src/blocks/toggle/block.json

+{
+	"$schema": "https://schemas.wp.org/trunk/block.json",
+	"apiVersion": 2,
+	"name": "woocommerce/product-toggle-field",


Register this server side too in https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Admin/Features/ProductBlockEditor/BlockRegistry.php#L22

joelclimbsthings · 2023-04-21T21:27:05Z

Thanks @mdperez86 , added in 2e4d857

mdperez86

Nice job @joelclimbsthings thanks for such great work here this LGTM!!!

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 20, 2023

joelclimbsthings force-pushed the add/stock-status-37884 branch from e3f71e8 to e616d28 Compare April 20, 2023 20:24

joelclimbsthings requested a review from a team April 20, 2023 20:25

joelclimbsthings self-assigned this Apr 20, 2023

joelclimbsthings marked this pull request as ready for review April 20, 2023 20:26

joelclimbsthings changed the title ~~Adding toggle block~~ Adding Stock status to inventory tab and toggle block Apr 20, 2023

mdperez86 reviewed Apr 21, 2023

View reviewed changes

packages/js/product-editor/src/blocks/inventory-quantity/block.json Outdated Show resolved Hide resolved

packages/js/product-editor/src/blocks/toggle/block.json Outdated Show resolved Hide resolved

joelclimbsthings requested a review from mdperez86 April 21, 2023 16:35

mdperez86 previously approved these changes Apr 21, 2023

View reviewed changes

joelclimbsthings dismissed mdperez86’s stale review via cdd630c April 21, 2023 18:52

joelclimbsthings force-pushed the add/stock-status-37884 branch from 41c7227 to cdd630c Compare April 21, 2023 18:52

mdperez86 previously approved these changes Apr 21, 2023

View reviewed changes

joelclimbsthings added 6 commits April 21, 2023 13:41

Adding toggle block

6d0d5db

Refactoring inventory fields block and adding stock status via radio

774454c

Add changelogs

c4bcfea

Adding field to block names

b2faab2

Resolving merge issues

f6105f4

Fixing images section spacing

289cc5e

joelclimbsthings dismissed mdperez86’s stale review via 289cc5e April 21, 2023 21:00

joelclimbsthings force-pushed the add/stock-status-37884 branch from cdd630c to 289cc5e Compare April 21, 2023 21:00

mdperez86 suggested changes Apr 21, 2023

View reviewed changes

Registering new blocks server side

2e4d857

github-actions bot added the focus: react admin [team:Ghidorah] label Apr 21, 2023

joelclimbsthings requested a review from mdperez86 April 21, 2023 21:27

mdperez86 approved these changes Apr 21, 2023

View reviewed changes

joelclimbsthings merged commit 3c5a967 into trunk Apr 21, 2023

joelclimbsthings deleted the add/stock-status-37884 branch April 21, 2023 21:49

github-actions bot added this to the 7.8.0 milestone Apr 21, 2023

Adding Stock status to inventory tab and toggle block #37906

Adding Stock status to inventory tab and toggle block #37906

Uh oh!

Conversation

joelclimbsthings commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Uh oh!

github-actions bot commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

github-actions bot commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joelclimbsthings commented Apr 21, 2023

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

mdperez86 Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

mdperez86 Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

joelclimbsthings commented Apr 21, 2023

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joelclimbsthings commented Apr 20, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023 •

edited

Loading