Skip to content

Conversation

@faisal-alvi
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Clear floats in Twenty Twenty Three theme on Related products and Upsells.

Closes #36785.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Add a new product or edit an existing one.
  2. Make sure to remove everything that is shown as a tab under the product description. Like, disabling the review, etc.
  3. Make sure you have related products or upsells enable and visible on the product page at FE.
  4. In trunk, see the related product/upsells section is not "cleared", i.e. it is touching the bottom of the Add to Cart button section.

image

  1. In this PR's fix branch, it clears the float and visible right after the product images (left) and the add to cart button (right).

image

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Apr 20, 2023
@woocommercebot woocommercebot requested review from a team and coreymckrill and removed request for a team April 20, 2023 09:13
Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, works as described in testing. Thanks @faisal-alvi !

@coreymckrill coreymckrill merged commit ddc94fc into woocommerce:trunk Apr 26, 2023
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Related products not clearing floats in Twenty Twenty Three theme

2 participants