Moving section icon svgs to assets folder and loading by URL #37869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelclimbsthings
changed the title
github-actions
bot
added
focus: react admin [team:Ghidorah]
plugin: woocommerce
Contributor
|
Hi @mdperez86, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Contributor
Test Results SummaryCommit SHA: 23670ea
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
mdperez86
reviewed
Apr 21, 2023
Contributor
mdperez86
left a comment
mdperez86
left a comment
There was a problem hiding this comment.
Nice job @joelclimbsthings LGTM! I just left some comments about the svg files properties.
Contributor
Author
|
Thanks @mdperez86 ! Great observations--I had just exported them straight from Figma, so it's a bit strange they weren't at least consistent. Fixed in 23670ea |
mdperez86
approved these changes
Apr 21, 2023
Contributor
mdperez86
left a comment
mdperez86
left a comment
There was a problem hiding this comment.
LGTM @joelclimbsthings thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Instead of injecting SVG directly into template, we're copying them as files into the assets folder and loading by URL.
Closes #37711 .
How to test the changes in this Pull Request:
pnpm --filter=woocommerce/client/admin run buildwoocommerce/assets/client/admindirectory contains aproduct-editor/iconsdirectory with all the previously built assets.product-block-editorfeature flag via WCA Test Helper plugin.