Skip to content

Conversation

@dkotter
Copy link
Contributor

@dkotter dkotter commented Apr 19, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

As reported in #32023, when using the Twenty Twenty One theme on smaller screens (less than 768px), when multiple products are in the cart, the remove icon does not properly show on every other item (so the 1st, 3rd, 5th, etc).

The issue here is we apply a custom CSS filter to each td element that gives us the alternating background colors. This ends up overlapping with the remove icon and in essence, hides it. This PR fixes this by adding a z-index and position argument to the close icon.

Closes #32023

Screenshots

Before fix After fix
before-fix after-fix

How to test the changes in this Pull Request:

  1. Install and activate the Twenty Twenty One theme
  2. Create two or more products in your store
  3. As a customer, add at least two of these products into your cart
  4. Go to the cart page on a small-screen device
  5. Ensure the remove icon shows properly for each product and that clicking on the icon works as expected

dkotter added 2 commits April 19, 2023 14:24
…oesn't show up properly when more than one product is in the cart
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Apr 19, 2023
@woocommercebot woocommercebot requested review from a team and barryhughes and removed request for a team April 19, 2023 20:32
Copy link
Member

@barryhughes barryhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, works as described—thank you!

@barryhughes barryhughes merged commit 83e6b55 into woocommerce:trunk Apr 19, 2023
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Twenty Twenty-One theme - Remove Product Button missing on alternate products

3 participants