Skip to content

Fix: variations are counted as products in import message of number of products imported #37829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Konamiman merged 11 commits into from
Apr 21, 2023
Merged

Fix: variations are counted as products in import message of number of products imported #37829

Konamiman merged 11 commits into from
Apr 21, 2023

Conversation

@mujuonly
Copy link
Contributor

@mujuonly mujuonly commented Apr 19, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Added the variations import count in the request response arrays and display in the message.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a site using Ninja tool.
  2. Install all the plugins.
  3. Tap on "Run the Setup wizard".
  4. Complete all the introductory tabs i.e., Store Details, Industry, Product types, Business details and Theme.
  5. Go to dashboard.
  6. Import a sample_products.csv file.
  7. After completion of import it should show 18 products imported. 7 variations imported. ( Instead of 25 products imported successfully )

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Apr 19, 2023
@woocommercebot woocommercebot requested review from a team and Konamiman and removed request for a team April 19, 2023 10:36
@mujuonly
Copy link
Contributor Author

mujuonly commented Apr 19, 2023

image

@louwie17 louwie17 self-requested a review April 19, 2023 15:24
@louwie17 louwie17 removed their request for review April 19, 2023 16:53
@mujuonly
Copy link
Contributor Author

mujuonly commented Apr 19, 2023

Unfortunately I could not fix the linting/tabulation issues, I'd appreciate if someone could fix for me.

@barryhughes
Copy link
Member

barryhughes commented Apr 19, 2023

I pushed a change fixing some of the indentation issues (though we will still need to review properly—please bear with us). Thanks!

@Konamiman Konamiman changed the title Variations are counted as products in import message of number of products imported Fix: variations are counted as products in import message of number of products imported Apr 21, 2023
@Konamiman Konamiman merged commit 9cfd58a into woocommerce:trunk Apr 21, 2023
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 21, 2023
@decodekult decodekult mentioned this pull request Nov 2, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Konamiman Konamiman Konamiman approved these changes

Assignees

@mujuonly mujuonly

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mujuonly @barryhughes @Konamiman @louwie17