Fix/37600 Remove aria-disabled from Update Cart button
#37820
Conversation
github-actions
bot
added
plugin: woocommerce
woocommercebot
requested review from
a team and
coreymckrill
and removed request for
a team
louwie17
left a comment
louwie17
left a comment
There was a problem hiding this comment.
Nice work @faisal-alvi, thanks for fixing this!
This PR tested well and the changes look good, I did leave one minor suggestion on the changelog description, but that can be optional (as we may adjust these upon release). Do let me know if you do decide to update the changelog (otherwise feel free to merge if you are able to).
| Significance: patch | ||
| Type: fix | ||
|
|
||
| The "Update Cart" button does not need an aria-disabled attribute, as it has a disabled attribute, this PR removes it. No newline at end of file |
There was a problem hiding this comment.
We don't have any specific guidelines around the changelog, but it might be worth re-wording this to reflect the actual change more, you could do something like this:
Removed aria-disabled attribute from "Update Cart" button as it already has a disabled attribute.
*editing the changelog file directly to update the description is fine.
There was a problem hiding this comment.
That makes sense, thanks for the suggestion. Implemented: e5c306d
There was a problem hiding this comment.
Thanks for updating it, I re-approved! Should be good to merge after all actions finish running.
louwie17
left a comment
louwie17
left a comment
There was a problem hiding this comment.
Thanks for updating the changelog :) LGTM 🚀
jorgeatorres
requested review from
jorgeatorres
and removed request for
coreymckrill
4 participants
Submission Review Guidelines:
Changes proposed in this Pull Request:
The "Update Cart" button does not need an aria-disabled attribute, as it has a disabled attribute, this PR removes it.
Closes #37600.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
aria-disabledattribute.