Skip to content

fix/37604: replace title html attribute with aria-label #37811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgeatorres merged 4 commits into from
Apr 28, 2023
Merged

fix/37604: replace title html attribute with aria-label #37811

jorgeatorres merged 4 commits into from
Apr 28, 2023

Conversation

@Sidsector9
Copy link
Contributor

@Sidsector9 Sidsector9 commented Apr 19, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

As per the recommendation, this PR removes the title attribute in favour of the aria-label attribute.

Closes #37604.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Install the Screen Reader Chrome extension
  2. Go to a single product page
  3. Tab until the quantity field is in focus
  4. Listen to the screen reader read out "Product Quantity"

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Apr 19, 2023
@woocommercebot woocommercebot requested review from a team and jorgeatorres and removed request for a team April 19, 2023 07:03
@Sidsector9 Sidsector9 changed the title fix/37604: fix/37604: replace title html attribute with aria-label Apr 19, 2023
@louwie17 louwie17 self-requested a review April 19, 2023 11:07
louwie17
louwie17 previously requested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested well, thanks for working on this 🎉
I just left one suggested change to update the template version, this should also help pass one of the required Github actions.

@Sidsector9 Sidsector9 requested a review from louwie17 April 21, 2023 08:09
jorgeatorres
jorgeatorres requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sidsector9!

Thanks for your contribution 💯. This works great.
I left a tiny tiny observation and that would be all from my side.

Please let me know what you think.

@jorgeatorres jorgeatorres self-requested a review April 28, 2023 18:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

jorgeatorres
jorgeatorres approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @Sidsector9!

@jorgeatorres jorgeatorres removed the request for review from louwie17 April 28, 2023 18:53
@jorgeatorres jorgeatorres merged commit 6fde831 into woocommerce:trunk Apr 28, 2023
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgeatorres jorgeatorres jorgeatorres approved these changes

@louwie17 louwie17 louwie17 left review comments

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Accessibility Improvements ‣ Product Page ‣ Quantity Input

4 participants

@Sidsector9 @jorgeatorres @louwie17 @peterfabian