fix/35860: Adds missing aria-label and tabindex HTML attributes to the Help tip element. #37808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugin: woocommerce
woocommercebot
requested review from
a team and
coreymckrill
and removed request for
a team
Sidsector9
changed the title
chihsuan
reviewed
Apr 19, 2023
Member
chihsuan
left a comment
chihsuan
left a comment
There was a problem hiding this comment.
Thanks for the fix! 👍
Except for the one in the comment, I confirmed the others are visible to screen readers now.
plugins/woocommerce/client/legacy/js/admin/meta-boxes-product.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Chi-Hsuan Huang <[email protected]>
chihsuan
approved these changes
Apr 19, 2023
Member
chihsuan
left a comment
chihsuan
left a comment
There was a problem hiding this comment.
LGTM and tested well!
I'll wait for @coreymckrill to take a look and merge it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37808 +/- ##
==========================================
- Coverage 51.5% 51.5% -0.0%
- Complexity 17261 17280 +19
==========================================
Files 429 430 +1
Lines 79957 80026 +69
==========================================
Hits 41215 41215
- Misses 38742 38811 +69
|
coreymckrill
approved these changes
Apr 19, 2023
Contributor
coreymckrill
left a comment
coreymckrill
left a comment
There was a problem hiding this comment.
Nice work @Sidsector9!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Adds missing
aria-labelandtabindexHTML attributes to the Help tip element.Closes #35860
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Products > Add New(/wp-admin/post-new.php?post_type=product).woocommerce-help-tipon the product edit page using Inspector tool on the trunk branch.aria-labelandtabindexattribute set.