Skip to content

Adding global product block editor styles #37805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louwie17 merged 11 commits into from
Apr 20, 2023
Merged

Adding global product block editor styles #37805

louwie17 merged 11 commits into from
Apr 20, 2023

Conversation

@joelclimbsthings
Copy link
Contributor

@joelclimbsthings joelclimbsthings commented Apr 19, 2023 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Refactoring and adding global styles for product block editor.

Figma: AkVNGImLgSqCObTQ3idVn7-fi-1005_135018

Closes #37687 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Checkout branch.
  2. Use WCA Test Helper plugin to enable product-block-editor feature flag.
  3. Go to Products -> Add new to see block editor.
  4. Look over all tabs / etc of block editor to ensure spacing and styles look correct. Use above Figma link for reference.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Apr 19, 2023
@joelclimbsthings joelclimbsthings marked this pull request as ready for review April 19, 2023 00:08
@joelclimbsthings joelclimbsthings requested a review from a team April 19, 2023 00:08
@joelclimbsthings joelclimbsthings self-assigned this Apr 19, 2023
@joelclimbsthings joelclimbsthings changed the title Removing unecessary class Adding global product block editor styles Apr 19, 2023
@joelclimbsthings joelclimbsthings force-pushed the update/block-editor-global-styling-37687 branch from 6eab78f to 5a18ff9 Compare April 19, 2023 15:59
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023 •
edited
Loading

Test Results Summary

Commit SHA: 8347eaa

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 53s
E2E Tests1870010019717m 44s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

joshuatf
joshuatf reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, Joel! Left a couple minor color changes.

Also curious if we can include the form error styles globally (.has-error) or if they need to remain in separate components.

@joelclimbsthings
Copy link
Contributor Author

joelclimbsthings commented Apr 19, 2023

Thanks @joshuatf , great observations! I believe I've remedied the colors and error styling, and noticed that the links don't have text decoration. Let me know what you think.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Hi @joshuatf,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

joshuatf
joshuatf approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing well and looks great! LGTM 🚢

@louwie17 louwie17 merged commit 7023a80 into trunk Apr 20, 2023
@louwie17 louwie17 deleted the update/block-editor-global-styling-37687 branch April 20, 2023 08:21
@github-actions github-actions bot added this to the 7.8.0 milestone Apr 20, 2023
@rodelgc
Copy link
Contributor

rodelgc commented Jun 1, 2023

Figma: AkVNGImLgSqCObTQ3idVn7-fi-1005_135018

Attaching screenshot from Figma
rlLzUUNHuU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joshuatf joshuatf joshuatf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joelclimbsthings joelclimbsthings

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.8.0

Development

Successfully merging this pull request may close these issues.

Match product editor global styling to designs

5 participants

@joelclimbsthings @rodelgc @joshuatf @louwie17