Fix checkbox label styling on product page tabs #37791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsherman
added
Bug
github-actions
bot
added
the
plugin: woocommerce
Contributor
|
Hi , @woocommerce/mothra-enhancements Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Contributor
Test Results SummaryCommit SHA: a0552e0
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37791 +/- ##
==========================================
- Coverage 51.6% 51.6% -0.0%
- Complexity 17260 17261 +1
==========================================
Files 429 429
Lines 79928 79942 +14
==========================================
- Hits 41213 41211 -2
- Misses 38715 38731 +16
|
nathanss
approved these changes
Apr 19, 2023
Contributor
nathanss
left a comment
nathanss
left a comment
There was a problem hiding this comment.
Thanks for the proactivity!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR fixes the styling of checkbox labels on the product page tabs for smaller viewports (
max-width: 1280px).This is not a new bug... it has existed since at least
2.5.0(I went back to that version and could reproduce it). To be honest, I'm not really sure why a very visible issue like this hasn't been fixed ever. Maybe I'm one of the few that regularly use a smaller viewport?Before
After
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/post-new.php?post_type=product)