Migrate Purchase task and dashboard utils to TS #37725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin [team:Ghidorah]
package: @woocommerce/data
chihsuan
commented
Apr 14, 2023
| profileItems: ProfileItems; | ||
| taskLists: Record< string, TaskListType >; | ||
| paymentMethods: Plugin[]; | ||
| productTypes: OnboardingProductType[]; |
Member
Author
There was a problem hiding this comment.
Onboarding productTypes is an object of objects.
Contributor
Test Results SummaryCommit SHA: ea8ea3f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
chihsuan
force-pushed
the
update/migrate-purchase-task-to-ts
branch
from
ab08c78 to
e929bbc
Compare
chihsuan
commented
Apr 14, 2023
| let theme = null; | ||
| if ( onboarding && onboarding.themes ) { | ||
| theme = onboarding.themes.find( | ||
| // @ts-expect-error Ignore TS error here, as we're removing the theme step and these code from OBW in another PR. |
Contributor
|
Hi @moon0326, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
chihsuan
force-pushed
the
update/migrate-purchase-task-to-ts
branch
from
9040f6d to
d749df1
Compare
chihsuan
force-pushed
the
update/migrate-purchase-task-to-ts
branch
from
d749df1 to
ea8ea3f
Compare
adrianduffell
approved these changes
May 5, 2023
Contributor
adrianduffell
left a comment
adrianduffell
left a comment
There was a problem hiding this comment.
This tested perfect, thanks @chihsuan! 🚀
Nice catch with the productTypes definition
ilyasfoo
approved these changes
May 8, 2023
| */ | ||
| export function getPriceValue( string ) { | ||
| return Number( decodeEntities( string ).replace( /[^0-9.-]+/g, '' ) ); | ||
| return { |
Contributor
There was a problem hiding this comment.
Nice touch! This feels more react-like
| generalSettings?.woocommerce_default_country | ||
| ) | ||
| ), | ||
| woocommerceTaxCountries.includes( countryCode ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #37190.
This PR migrates the Purchase task to TS. To archive that, I migrated the
dashboard/utils.jsas well.Besides, this PR also fixes a wrong type definition (
productTypes) in@woocommerce/dataonboarding store.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
CI should pass
Onboarding wizard > Product Typestab (/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=product-types)MembershipsWooCommerce > HomeAdd ... product to my storetask (for example:Add Memberships and 1 more product to my store)Would you like to add the following paid features to your store now?Buy nowbutton