Print blocks-based element CSS classes only when a block theme is used #37631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: 0863a76
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Contributor
|
Hi @jorgeatorres, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Aljullu
approved these changes
Apr 11, 2023
Contributor
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
LGTM, thanks @xristos3490!
Even though I'm approving from my side, I assigned somebody from Proton to do the last review.
Aljullu
requested review from
a team and
jorgeatorres
and removed request for
a team
jorgeatorres
approved these changes
Apr 28, 2023
Member
jorgeatorres
left a comment
jorgeatorres
left a comment
There was a problem hiding this comment.
LGTM. Thanks @xristos3490!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR aims to remove blocks-based CSS classes from elements when the current theme is not an FSE theme. This should minimize the footprint of FSE-related changes for legacy themes.
Hint for the reviewer: There is also a risk involved in this PR. Please check the issue description for details.
Closes #37630
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
wp-element-buttonclass is only added in the FSE theme.