Update deprecated jQuery ready calls #37320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Removes deprecated jQuery
readyhandler signatureCloses #33322 .
How to test the changes in this Pull Request:
Have you followed the Writing high-quality testing instructions guide?
Spin up WooCommerce environment without this patch applied (I used wp-env - SCRIPT_DEBUG should be enabled, I think)
Go through setup steps or disable the setup wizard
View admin dashboard
See WooCommerce status widget
See deprecation logged in console (
JQMIGRATE: 'ready' event is deprecated [jquery-migrate.js:100:12](http://localhost:8888/wp-includes/js/jquery/jquery-migrate.js?ver=3.3.2))Apply patch
See there is no longer a deprecation logged
Other information:
pnpm --filter=<project> changelog add?An e2e test could probably ensure that the WooCommerce events that are supposed to fire actually fire. Currently does not seem to be tested.
FOR PR REVIEWER ONLY: