Skip to content

Conversation

@ethanclevenger91
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Removes deprecated jQuery ready handler signature

Closes #33322 .

How to test the changes in this Pull Request:

  • Have you followed the Writing high-quality testing instructions guide?

  • Spin up WooCommerce environment without this patch applied (I used wp-env - SCRIPT_DEBUG should be enabled, I think)

  • Go through setup steps or disable the setup wizard

  • View admin dashboard

  • See WooCommerce status widget

  • See deprecation logged in console (JQMIGRATE: 'ready' event is deprecated [jquery-migrate.js:100:12](http://localhost:8888/wp-includes/js/jquery/jquery-migrate.js?ver=3.3.2))

  • Apply patch

  • See there is no longer a deprecation logged

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
  • Have you included testing instructions?

An e2e test could probably ensure that the WooCommerce events that are supposed to fire actually fire. Currently does not seem to be tested.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Mar 20, 2023
@woocommercebot woocommercebot requested review from a team and jorgeatorres and removed request for a team March 20, 2023 21:56
@ethanclevenger91 ethanclevenger91 changed the title Fix/33322 Update deprecated jQuery ready calls Mar 20, 2023
@samueljseay samueljseay added the needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. label May 4, 2023
@samueljseay samueljseay requested review from a team and barryhughes and removed request for a team and jorgeatorres May 4, 2023 08:24
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@jorgeatorres jorgeatorres requested review from jorgeatorres and removed request for barryhughes May 4, 2023 10:53
Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jorgeatorres jorgeatorres merged commit d6931f3 into woocommerce:trunk May 23, 2023
@github-actions github-actions bot added this to the 7.9.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jquery - ready event not fired because deprecated

3 participants