Skip to content

Fix/36530 settings tables styles #36531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
octaedro merged 3 commits into from
Jan 21, 2023
Merged

Fix/36530 settings tables styles #36531

octaedro merged 3 commits into from
Jan 21, 2023

Conversation

@octaedro
Copy link
Contributor

@octaedro octaedro commented Jan 20, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This PR adds the changes to add a tooltip to the advanced settings tables without breaking other settings tables.

Screenshot 2023-01-20 at 15 04 13

Closes #36530 .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Install a plugin that adds new settings like WooCommerce Payments
  2. Go to WooCommerce > Settings > Subscriptions
  3. Verify that the table looks ok.

New
Screenshot 2023-01-20 at 13 27 43

Broken
Screenshot 2023-01-20 at 13 27 04

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 20, 2023
@octaedro octaedro marked this pull request as ready for review January 20, 2023 18:11
@octaedro octaedro requested a review from a team January 20, 2023 18:11
@octaedro octaedro self-assigned this Jan 20, 2023
@octaedro octaedro mentioned this pull request Jan 20, 2023
Merged
8 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited
Loading

Test Results Summary

Commit SHA: d60da27

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 8s
E2E Tests189006019515m 47s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro dismissed a stale review via d60da27 January 20, 2023 19:26
joshuatf
joshuatf approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the issue with the subscriptions checkbox layout! 🚢

@octaedro octaedro merged commit 71a7bd4 into trunk Jan 21, 2023
@octaedro octaedro deleted the fix/36530_settings_tables_styles branch January 21, 2023 20:34
@github-actions github-actions bot added this to the 7.4.0 milestone Jan 21, 2023
vedanshujain pushed a commit that referenced this pull request Jan 25, 2023
@octaedro @vedanshujain
Fix/36530 settings tables styles (#36531)
5bcaa0f 
* Fix settings tables

* Add changelog

* Fix lint

Co-authored-by: Fernando Marichal <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joshuatf joshuatf joshuatf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@octaedro octaedro

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

Advanced settings tables are broken

3 participants

@octaedro @joshuatf