Skip to content

Conversation

@Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jan 17, 2023

All Submissions:

Changes proposed in this Pull Request:

Include some changes to TT3 style sheet to fix some styling with the notices. This PR contains two commits, the first one fixes indentation, the second one implements the CSS fixes.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Install Twenty Twenty-Three.
  2. Go to several pages that display a notice, ie:
  • to a Single product page and add the product to your cart
  • My Account > Orders (if you hadn't done any orders)
  1. Make sure the notices look correct and there aren't misaligned elements.
WC 7.3 This branch
imatge imatge
imatge imatge
imatge imatge

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 17, 2023
@Aljullu Aljullu requested review from a team and jorgeatorres and removed request for a team January 17, 2023 14:37
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 4e3e6ed

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests189006019513m 55s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@jorgeatorres jorgeatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@jorgeatorres jorgeatorres merged commit f3a2783 into trunk Jan 18, 2023
@jorgeatorres jorgeatorres deleted the fix/notices-styling-tt3 branch January 18, 2023 16:51
@github-actions github-actions bot added this to the 7.4.0 milestone Jan 18, 2023
adrianduffell pushed a commit that referenced this pull request Jan 20, 2023
* Fix TT3 notices CSS identation

* Fix notices styling in Twenty Twenty-Three
vedanshujain pushed a commit that referenced this pull request Jan 25, 2023
* Fix TT3 notices CSS identation

* Fix notices styling in Twenty Twenty-Three
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants