Widen the selector used to hide the quantity input #36384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are sold individually).
github-actions
bot
added
the
plugin: woocommerce
barryhughes
requested review from
a team and
coreymckrill
and removed request for
a team
Contributor
Test Results SummaryCommit SHA: 83c9466
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
coreymckrill
approved these changes
Jan 13, 2023
Contributor
coreymckrill
left a comment
coreymckrill
left a comment
There was a problem hiding this comment.
👍 Works as described
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to #36350, we just restored the default of hiding the quantity selector for any products that are sold individually.
Following some further feedback, this change adjusts the selector so it hides the entire
.quantitydiv (important because some themes add their own increment/decrement buttons within the div, and we don't want those to remain visible when the input is hidden).How to test the changes in this Pull Request:
Testing is as per earlier PR #36350 ... just as for that PR, you may wish to test this change alongside any of the default Twenty X themes (or indeed with a generic non-default theme, so long as it does not override and replace our stylesheets). Note that the change cannot currently be seen using Storefront, because that theme replaces our default styles (ie, we need to make a separate change within that product).
💡 After checking out this branch, rebuild the relevant stylesheets using
pnpm run --filter='woocommerce/client/legacy' build. You may also need to clear your browser cache to see the change.This change should have no impact outside of single product pages.
FOR PR REVIEWER ONLY: