Add advanced setting option #36380

octaedro · 2023-01-11T19:26:22Z

All Submissions:

Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR adds a new setting in Settings > Advanced > Features.
The setting should be disabled by default unless it was enabled through the flows described in #36161 and #36162
Include a tooltip to describe the new exp briefly.

Closes #36163.

This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Go to WooCommerce > Settings > Advanced > Features.
Verify the option New product editor is available to toggle. The description is: "Try the new product editor (Beta)" and the tooltip text says: "Enable to try the new, simplified product editor (currently in development and only available for simple products). No extension support yet."
Enable the New product editor and verify that the new experience is turned on.
Verify that the toggle works correctly.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

github-actions · 2023-01-11T19:39:10Z

Test Results Summary

Commit SHA: 347b553

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 9s
E2E Tests	189	0	0	6	0	195	18m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

joshuatf

Looks great and the toggle is working well! My tooltip HTML is coming out escaped though. Is there another branch or some setting needed for this to work?

Additionally, the warning from the other plugins being active prevents activation of the feature. This does not need to be tackled in this PR, but seems a little opinionated and prevents us from using features as intended to roll out experimental features.

cc @Konamiman if you have more context around those decisions.

Konamiman · 2023-01-12T08:33:35Z

Hi @octaedro and @joshuatf. There's a legacy features array in the class: $this->legacy_feature_ids = array( 'analytics', 'new_navigation' );. new_product_management should be added to this list, not only for the is_legacy_feature method to work as expected, but also because this will prevent the "incompatible plugins" warning from being shown.

This warning exists to keep site admins informed about the declared compatibility of other plugins with newly introduced WooCommerce features. Maybe this could be selectively disabled by adding a new flag in the features array that is generated in the constructor, but as you said that would be a job for a different pull request.

octaedro · 2023-01-12T14:50:35Z

Thank you @Konamiman and @joshuatf for your answers.

I just addressed the changes you mentioned. @joshuatf Could you take another look at this PR?

joshuatf

This is testing well for me and LGTM, thanks for the changes, @octaedro!

Thanks for the insight, @Konamiman! I think we might look into either making the compatibility catches opt-in or at least changing the terms legacy so that we can ship new features without risk of them being unusable.

@octaedro do you want to create a follow-up issue around that or would you like me to?

joshuatf

LGTM! Nice work getting those e2e tests fixed up 🎉

barryhughes · 2023-01-19T00:28:18Z

plugins/woocommerce/includes/admin/class-wc-admin-settings.php

 							?>
 								<tr valign="top" class="<?php echo esc_attr( implode( ' ', $visibility_class ) ); ?>">
 									<th scope="row" class="titledesc"><?php echo esc_html( $value['title'] ); ?></th>
+									<td class="help-tooltip"><?php echo isset( $value['tooltip'] ) && '' !== $value['tooltip'] ? wc_help_tip( esc_html( $value['tooltip'] ) ) : ''; ?></td>


Interestingly, this new cell creates an issue on the WooCommerce ▸ Settings ▸ Advanced ▸ Custom Data Stores screen, effectively displacing some other settings (because the rows above and below contain just two table cells):

I haven't had a chance to look in any depth—I just noticed while working on some HPOS stuff—but I wonder if this is causing a problem on other screens, too (and/or what the best solution is).

cc @octaedro

Does indeed impact a few places:

(Settings > Advanced)

Thank you @barryhughes for reporting this.
I just created a PR to fix that.

github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jan 11, 2023

octaedro changed the title ~~Add/36163 advanced setting option~~ Add advanced setting option Jan 11, 2023

octaedro requested a review from a team January 11, 2023 20:02

octaedro self-assigned this Jan 11, 2023

octaedro added the focus: product management label Jan 11, 2023

octaedro marked this pull request as ready for review January 11, 2023 20:03

joshuatf reviewed Jan 11, 2023

View reviewed changes

octaedro added 8 commits January 12, 2023 11:33

Modify feature flag

ed5370d

Add tooltip to WC > Settings > Advanced > Features

83089d8

Add Settings option

fbbb5e8

Add optional_features and beta_features option

97b3246

Add changelog

87f7d56

Fix lint

f06e3bb

Fix lint

e05cdab

Add new_product_management to legacy features

039ff46

octaedro force-pushed the add/36163_advanced_setting_option branch from a5075db to 039ff46 Compare January 12, 2023 14:47

octaedro requested a review from joshuatf January 12, 2023 14:50

Fix escaped tooltip

f15acfb

joshuatf previously approved these changes Jan 12, 2023

View reviewed changes

octaedro mentioned this pull request Jan 12, 2023

Enable new experience when new user selects "Physical product" #36406

Merged

8 tasks

Fix Analytics pages e2e tests

8ce54c5

octaedro dismissed joshuatf’s stale review via 8ce54c5 January 13, 2023 17:10

Fix Payment setup task e2e tests

347b553

octaedro requested a review from joshuatf January 13, 2023 18:31

joshuatf approved these changes Jan 13, 2023

View reviewed changes

octaedro merged commit c5a27cb into trunk Jan 13, 2023

octaedro deleted the add/36163_advanced_setting_option branch January 13, 2023 20:04

github-actions bot added this to the 7.4.0 milestone Jan 13, 2023

barryhughes reviewed Jan 19, 2023

View reviewed changes

octaedro mentioned this pull request Jan 20, 2023

Advanced settings tables are broken #36530

Closed

github-actions bot mentioned this pull request Feb 15, 2023

Test WooCommerce 7.4 UVLabs/location-picker-at-checkout-for-woocommerce#60

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add advanced setting option #36380

Add advanced setting option #36380

Uh oh!

octaedro commented Jan 11, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Jan 11, 2023 •

edited

Loading

Uh oh!

joshuatf left a comment •

edited

Loading

Uh oh!

Konamiman commented Jan 12, 2023

Uh oh!

octaedro commented Jan 12, 2023

Uh oh!

joshuatf left a comment

Uh oh!

joshuatf left a comment

Uh oh!

barryhughes Jan 19, 2023

Uh oh!

barryhughes Jan 20, 2023

Uh oh!

octaedro Jan 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add advanced setting option #36380

Add advanced setting option #36380

Uh oh!

Conversation

octaedro commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

FOR PR REVIEWER ONLY:

Uh oh!

github-actions bot commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

joshuatf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Konamiman commented Jan 12, 2023

Uh oh!

octaedro commented Jan 12, 2023

Uh oh!

joshuatf left a comment

Choose a reason for hiding this comment

Uh oh!

joshuatf left a comment

Choose a reason for hiding this comment

Uh oh!

barryhughes Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

barryhughes Jan 20, 2023

Choose a reason for hiding this comment

Uh oh!

octaedro Jan 20, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

octaedro commented Jan 11, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2023 •

edited

Loading

joshuatf left a comment •

edited

Loading