Remove button styles if the block theme has button styles defined in theme.json #36225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
requested review from
a team and
jorgeatorres
and removed request for
a team
github-actions
bot
added
the
plugin: woocommerce
Aljullu
commented
Dec 29, 2022
Comment on lines
+1657
to
+1658
| .woocommerce:where(body:not(.woocommerce-block-theme-has-button-styles)), | ||
| :where(body:not(.woocommerce-block-theme-has-button-styles)) .woocommerce { |
Contributor
Author
There was a problem hiding this comment.
FYI to ease the review: I hadn't made any changes to the styles below 👇 , they appear in the diff because they were moved from another section of the document.
Aljullu
requested review from
a team and
gigitux
and removed request for
a team
Contributor
Test Results SummaryCommit SHA: 37e9502
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Contributor
Author
|
@jorgeatorres, is this PR on your radar? Wondering if there is anything we can do to help this being merged in time for WC 7.4. |
jorgeatorres
approved these changes
Jan 18, 2023
Member
jorgeatorres
left a comment
jorgeatorres
left a comment
There was a problem hiding this comment.
LGTM. Thank you @Aljullu!
jorgeatorres
deleted the
fix/remove-button-styles-when-custom-block-theme
branch
adrianduffell
pushed a commit
that referenced
this pull request
Jan 20, 2023
…theme.json (#36225) * Remove button styles if the block theme has their own * Fix button style in TT2
vedanshujain
pushed a commit
that referenced
this pull request
Jan 25, 2023
…theme.json (#36225) * Remove button styles if the block theme has their own * Fix button style in TT2
5 tasks
4 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds a
.woocommerce-block-theme-has-button-stylesclass to thebodyelement of the page if the theme in use is a block theme that defines button styles intheme.jsonusing the Elements API. Using that class, we then disable all button styling provided by WC core (I used a:where()selector so these changes shouldn't affect the specificity of CSS selectors).Closes woocommerce/woocommerce-blocks#7972 (Shop and product page buttons).
How to test the changes in this Pull Request:
theme.jsonand is not Twenty Twenty-Three.trunkand this branch.Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: