Skip to content

Update country select control regex #36159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 3 commits into from
Dec 23, 2022
Merged

Update country select control regex #36159

moon0326 merged 3 commits into from
Dec 23, 2022

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Dec 23, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #36120

This PR updates regex used in the country select control to match a country name or - state. The previous change only matched a country name

How to test the changes in this Pull Request:

  1. Start OBW
  2. Type a country name and confirm it matches a country
  3. Type a state name and confirm it matches a state

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 requested review from a team, chihsuan and ilyasfoo December 23, 2022 03:58
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 23, 2022
ilyasfoo
ilyasfoo previously approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2022 •
edited
Loading

Test Results Summary

Commit SHA: f43c799

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 3s
E2E Tests187006019316m 3s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@moon0326 moon0326 merged commit 52640de into trunk Dec 23, 2022
@moon0326 moon0326 deleted the update/36120-selectcontrol-filtering-only-filters-from-position-0 branch December 23, 2022 05:30
@github-actions github-actions bot added this to the 7.4.0 milestone Dec 23, 2022
@roykho roykho modified the milestones: 7.4.0, 7.3.0 Dec 29, 2022
This was referenced Dec 29, 2022
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Dec 29, 2022
Update country select control regex (#36159)
fef9b74 
* Update regex to match country name or " - region "

* Add changelog

* Fix style
roykho pushed a commit that referenced this pull request Dec 29, 2022
@github-actions
Cherry pick 36159 into release/7.3 (#36230)
3be7777 
* Update country select control regex (#36159)

* Update regex to match country name or " - region "

* Add changelog

* Fix style

* Prep for cherry pick 36159

Co-authored-by: Moon <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
joelclimbsthings pushed a commit that referenced this pull request Jan 6, 2023
@joelclimbsthings
Update country select control regex (#36159)
5f96176 
* Update regex to match country name or " - region "

* Add changelog

* Fix style
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan Awaiting requested review from chihsuan

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

SelectControl filtering only filters from position 0 of a text

4 participants

@moon0326 @ilyasfoo @roykho