Skip to content

Conversation

@ilyasfoo
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Fix to #36003

Remove a redundant Pinterest plugin shown in the marketing task.

image

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

With a new site,

  1. Disable Display suggestions within WooCommerce in WooCommerce > Settings > Advanced > WooCommerce.com
  2. Go to WooCommerce > Home > Get more sales
  3. Observe Pinterest plugin is only shown once

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo added this to the 7.3.0 milestone Dec 23, 2022
@ilyasfoo ilyasfoo requested review from a team, chihsuan and moon0326 December 23, 2022 02:58
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 23, 2022
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: e9c4953

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests187006019312m 58s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fro fixing it quickly. LGTM and tested well! 👍

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rjchow rjchow merged commit 61ee3eb into trunk Dec 26, 2022
@rjchow rjchow deleted the fix/remove-redundant-pinterest-from-marketing-task branch December 26, 2022 04:17
github-actions bot pushed a commit that referenced this pull request Dec 26, 2022
* Remove redundant pinterest plugin shown in marketing task
roykho pushed a commit that referenced this pull request Dec 29, 2022
* Remove redundant Pinterest listing from marketing task (#36158)

* Remove redundant pinterest plugin shown in marketing task

* Prep for cherry pick 36158

Co-authored-by: Ilyas Foo <[email protected]>
Co-authored-by: WooCommerce Bot <[email protected]>
joelclimbsthings pushed a commit that referenced this pull request Jan 6, 2023
* Remove redundant pinterest plugin shown in marketing task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants