Make sure attribute term dropdown adheres to sort order setting #36047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: 47ac958
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
joelclimbsthings
requested review from
joelclimbsthings
and removed request for
a team
| <select multiple="multiple" | ||
| data-minimum_input_length="0" | ||
| data-limit="50" data-return_id="id" | ||
| data-placeholder="<?php esc_attr_e( 'Select terms', 'woocommerce' ); ?>" |
Contributor
There was a problem hiding this comment.
phew 😅
Thanks for straightening these out!
joelclimbsthings
approved these changes
Dec 20, 2022
Contributor
joelclimbsthings
left a comment
joelclimbsthings
left a comment
There was a problem hiding this comment.
Working well for me! And definite improvement in the code 🚢
joelclimbsthings
pushed a commit
that referenced
this pull request
Jan 6, 2023
* Make sure attribute term dropdown adheres to sort order setting of attribute * Fix spacing * Fix lint errors
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This fixes a bug introduced in #34744 where we default the sort order to
id. This change makes use of theorderbysetting in attributes and defaults tonameif it is not set.Closes #35639 .
How to test the changes in this Pull Request:
nameCustom orderingorTerm IDand see if the order within the product edit screen matches what is set.Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: