Skip to content

Conversation

@louwie17
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This makes sure we only add the top when the row is expanded to account for the product image.
This fixes an issue were the dropdown arrow shows up on the previous row (see picture in original issue).

Closes #34534 .

Screen Shot 2022-12-16 at 11 04 05 AM

Screen Shot 2022-12-16 at 11 04 38 AM

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Load this branch, make sure you have some products and go to Products > All Products on a phone or changing your browser viewport to a mobile viewport.
  2. The dropdown arrow should show in the top right and open the same row it's in.
  3. Upon expansion the arrow should still show in the top right.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@louwie17 louwie17 requested a review from a team December 16, 2022 10:06
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 16, 2022
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: a539f26

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 54s
E2E Tests187006019314m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@louwie17 louwie17 self-assigned this Dec 19, 2022
@joelclimbsthings joelclimbsthings requested review from joelclimbsthings and removed request for a team December 20, 2022 19:27
Copy link
Contributor

@joelclimbsthings joelclimbsthings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well, nice job @louwie17 ! 🚢

@louwie17 louwie17 merged commit 1e815be into trunk Dec 21, 2022
@louwie17 louwie17 deleted the fix/34534_product_dropdown_on_mobile branch December 21, 2022 08:11
@github-actions github-actions bot added this to the 7.4.0 milestone Dec 21, 2022
joelclimbsthings pushed a commit that referenced this pull request Jan 6, 2023
* Only add top when product row is expanded.

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown menus are on the row before on mobile

3 participants