Skip to content

Add Codisto Extension to Onboarding #36009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrianduffell merged 9 commits into from
Dec 15, 2022
Merged

Add Codisto Extension to Onboarding #36009

adrianduffell merged 9 commits into from
Dec 15, 2022

Conversation

@adrianduffell
Copy link
Contributor

@adrianduffell adrianduffell commented Dec 15, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes (partially) #35871 .

Adds Codistro for WooCommerce to Onboarding Wizard and Marketing Task.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Onboarding Wizard

With a new site,

  1. Skip the Onboarding Wizard.
  2. Disable "Display suggestions within WooCommerce " in Settings > Advanced > WooCommerce.com.
  3. Navigate to the Free Features section in the Onboarding Wizard.
  4. See that Codisto is listed.
  5. Seet the word Codisto links to https://woocommerce.com/pt-br/products/amazon-ebay-integration/?quid=c247a85321c9e93e7c3c6f1eb072e6e5 in a new tab.
  6. Select Codistro and complete the Onboarding Wizard.
  7. On the WordPress Plugins page, confirm that "Codisto Channel Cloud" plugin is installed.

Marketing Task

  1. On the WordPress Plugins page, delete "Codisto Channel Cloud" plugin if it exists.
  2. On WooCommerce Home, click the Marketing Task (Get more sales).
  3. See that Codistro for WooCommerce is listed.
  4. Click "Get Started" button on Codistro for WooCommerce.
  5. Wait for Install.
  6. See that Codisto move to "Installed marketing extensions"
  7. Click "Manage" button.
  8. See that Codistro for WooCommerce manage page loads.

Screenshots

image (3)
image (2)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 15, 2022
@adrianduffell adrianduffell requested review from a team, chihsuan and rjchow December 15, 2022 11:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022 •
edited
Loading

Test Results Summary

Commit SHA: a201047

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 54s
E2E Tests187006019314m 40s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! @adrianduffell LGTM. 💯

@adrianduffell adrianduffell merged commit dbbe78c into trunk Dec 15, 2022
@adrianduffell adrianduffell deleted the add/codisto-onboarding branch December 15, 2022 12:34
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 15, 2022
@adrianduffell
Copy link
Contributor Author

adrianduffell commented Dec 15, 2022

Thanks for the assist on this one too @chihsuan 🙌

samueljseay pushed a commit that referenced this pull request Dec 15, 2022
@adrianduffell @chihsuan @samueljseay
Add Codisto Extension to Onboarding (#36009)
6b76610 
* WIP

* Update codistoconnect

* Update selective-extensions-bundle for free trial badge

* Add codisto onboarding logo

* Add changelog

* Fix lint issues

* Fix lint issues with necassary spacing this time

* Add link to codisto product page

* Fix lint formatting

Co-authored-by: Chi-Hsuan Huang <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
@chihsuan chihsuan mentioned this pull request Jan 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@rjchow rjchow Awaiting requested review from rjchow

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianduffell @chihsuan