Add pagination to variations list #35979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
focus: react admin
plugin: woocommerce
Contributor
Author
|
This PR is blocked by #35976 |
Contributor
Test Results SummaryCommit SHA: 5a9578f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
joshuatf
previously approved these changes
Dec 14, 2022
Contributor
joshuatf
left a comment
joshuatf
left a comment
There was a problem hiding this comment.
Testing well and code looks great! Left one comment about adding in the text transform we discussed earlier, but pre-approving ✅
| margin: 0; | ||
| } | ||
|
|
||
| &__footer { |
Contributor
There was a problem hiding this comment.
I know @jarekmorawski hasn't responded yet on whether or not we want to change this for all pagination components, but in the meantime I think it would be okay to update the styling just for variations to the casing in the design.
github-actions
bot
added
the
package: @woocommerce/components
joshuatf
reviewed
Dec 14, 2022
plugins/woocommerce-admin/client/products/fields/variations/variations.scss
Outdated
Show resolved
Hide resolved
joshuatf
approved these changes
Dec 14, 2022
Contributor
joshuatf
left a comment
joshuatf
left a comment
There was a problem hiding this comment.
This looks great and is testing well on my end!
I committed one minor style change (feel free to revert if I was incorrect on this or if the styling looks different on your end) so that you can merge without needing to get approval again.
5 tasks
samueljseay
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Add changelog * Add pagination to variations list * Apply styles for pagination paddings and to keep it at the bottom of the section card * Returning back per page option from 2 to 25 * Fix pagination label text from uppercase to normal and font styles * Update variation footer gap Co-authored-by: Joshua T Flowers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #35788
How to test the changes in this Pull Request:
Products -> Add Newpage or use and existing variable product/wp-admin/admin.php?page=wc-admin&path=/product/{product_id}. Replace the{product_id}string with your real id.Optionstab and in theVariationssection you should see the pagination component at the botton of the list if and only if the product has more than 25 variations and if the items per page is less than the total amount of variations.Screen.Recording.2022-12-14.at.2.41.27.PM.mov
Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: