Skip to content

Conversation

@mdperez86
Copy link
Contributor

@mdperez86 mdperez86 commented Dec 14, 2022

All Submissions:

Changes proposed in this Pull Request:

Fixes #35706

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Navigate to the new product management experience (Products -> Add new (MVP))
  2. Click the various tabs in the header to navigate between product sections (General/Pricing/etc)
  3. Make sure that all content is shown and works as expected
  4. Narrow your viewport to make sure that the header placement works with various screen sizes
  5. Scroll down inside a given tab and then click another tab to make sure you're scrolled back to the top

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 14, 2022
@mdperez86 mdperez86 self-assigned this Dec 14, 2022
@mdperez86 mdperez86 marked this pull request as ready for review December 14, 2022 15:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

Test Results Summary

Commit SHA: e5d2eb9

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 52s
E2E Tests187006019321m 55s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top navigation tabs [MVP]

3 participants