Include taxes migration in the states migrator helper method #35967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Contributor
Test Results SummaryCommit SHA: 5b3f360
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
peterfabian
requested changes
Dec 14, 2022
Contributor
peterfabian
left a comment
peterfabian
left a comment
There was a problem hiding this comment.
Thanks, this works well.
Besides the PHPCS below, I think we need to fix also the version strings in class-wc-install
'7.2.0' => array(
'wc_update_720_adjust_new_zealand_states',
'wc_update_720_adjust_ukraine_states',
),
| private static function migrate_country_states_for_tax_rates( string $country_code, array $old_to_new_states_mapping ): void { | ||
| global $wpdb; | ||
|
|
||
| // phpcs:disable WordPress.DB.PreparedSQL.NotPrepared |
Contributor
There was a problem hiding this comment.
I think if you put the $wpdb->prepare() directly into the $wpdb->query(), the phpcs disabling won't be necessary.
It's probably true for some other ones above, but this is fairly simple to change.
Contributor
Author
There was a problem hiding this comment.
I'll change it but in general I prefer to first generate the query in a separate variable and then run it, as the resulting code is cleaner than a nested query(prepare($sql)), even if it's at the expense of having to disable the check.
peterfabian
previously approved these changes
Dec 14, 2022
Contributor
peterfabian
left a comment
peterfabian
left a comment
There was a problem hiding this comment.
Thanks, looks good to me now!
peterfabian
approved these changes
Dec 14, 2022
samueljseay
pushed a commit
that referenced
this pull request
Dec 15, 2022
samueljseay
added a commit
that referenced
this pull request
Dec 16, 2022
* Include taxes migration in the states migrator helper method (#35967) * Prep for cherry pick 35967 * Move 7.2.1 fixes to separate heading in readme.txt Co-authored-by: Néstor Soriano <[email protected]> Co-authored-by: WooCommerce Bot <[email protected]> Co-authored-by: Sam Seay <[email protected]>
5 tasks
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#35669 introduced a helper method to migrate state codes in various places of the database (shipping locations, orders, store address) but one placed that was missing is the tax rates table. This pull request fixes that.
How to test the changes in this Pull Request:
Same testing instructions of #35669 but this time testing that the state codes in the tax rates (WooCommerce - Settings - Tax - Standard, Reduced and Zero taxes) are properly updated.
Other information:
pnpm --filter=<project> changelog add?FOR PR REVIEWER ONLY: