Change the default currency for Croatia to Euros #35963
Conversation
We do not completely remove the Kuna (HKR) even after the grace period ends (2022-01-15), since an automatic switch to Euros in the storefront, without any sort of conversion, could be challenging for merchants.
github-actions
bot
added
the
plugin: woocommerce
barryhughes
requested review from
a team and
jorgeatorres
and removed request for
a team
Test Results SummaryCommit SHA: 7592d1e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Hi @barryhughes! This looks good to me, but I wonder if it actually closes #35872 as it doesn't enforce this part:
Not a blocker, and something we can do in a follow-up issue, but then that issue will be as urgent as this one. I suppose we could just deal with that after the 2nd week of January (by removing references to HRK and updating the currency) but I wonder if that'd be best to include here (and now). What are your thoughts? |
…in 7.3 (post-transition).
|
So to expand on this part:
In practice, new stores will be shepherded into using EUR as of this change. I get the spirit of the above statement, but it's a tricky proposition for us and I think blocking the ability to select HRK (without removing it completely—not sure we can safely do that without migration code) is going to be a hard ask. Imho, it makes more sense to circle back after a decent interval of time has passed and remove it then. |
jorgeatorres
left a comment
jorgeatorres
left a comment
There was a problem hiding this comment.
LGTM. Thank you @barryhughes!
* Change the default currency for Croatia to Euros, beginning 2023-01-01. We do not completely remove the Kuna (HKR) even after the grace period ends (2022-01-15), since an automatic switch to Euros in the storefront, without any sort of conversion, could be challenging for merchants. * Simplify: we don't need the date-conditional because we are shipping in 7.3 (post-transition). * Whitespace. * Update continents test to account for Croatia currency change. * Further change to API test for continents/currencies.
* Change the default currency for Croatia to Euros, beginning 2023-01-01. We do not completely remove the Kuna (HKR) even after the grace period ends (2022-01-15), since an automatic switch to Euros in the storefront, without any sort of conversion, could be challenging for merchants. * Simplify: we don't need the date-conditional because we are shipping in 7.3 (post-transition). * Whitespace. * Update continents test to account for Croatia currency change. * Further change to API test for continents/currencies.
* Change the default currency for Croatia to Euros (#35963) * Change the default currency for Croatia to Euros, beginning 2023-01-01. We do not completely remove the Kuna (HKR) even after the grace period ends (2022-01-15), since an automatic switch to Euros in the storefront, without any sort of conversion, could be challenging for merchants. * Simplify: we don't need the date-conditional because we are shipping in 7.3 (post-transition). * Whitespace. * Update continents test to account for Croatia currency change. * Further change to API test for continents/currencies. * Prep for cherry pick 35963 Co-authored-by: Barry Hughes <[email protected]> Co-authored-by: WooCommerce Bot <[email protected]>
Beginning 2023-01-01, Croatia starts using the Euro. For any new stores with a base of operations in Croatia, this should be the default currency from January 1st onwards (though it will still be possible for merchants to manually switch back to HKR if preferred).
For existing stores, no automated change will take place (or, not via the work contained in this PR).
Closes #35872.
How to test the changes in this Pull Request:
(Updated! We simplified this a lot.)
Croatia.Euro (€).Other information:
i18n/locale-info.php.i18n/local-info.phpfilterable (and we could then make these tweaks via a filter function). Let me know if that's something we prefer to do ... however, since I don't think there has so far been any demand for such a filter I preferred to make a minimal change that does not expand our public API surface any further.HKRin the future, post-transition (when it ceases to be a valid currency), but we can also handle that at some later point/via the follow-up issue.FOR PR REVIEWER ONLY: