Skip to content

Cleanup product task experiment #35950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 8 commits into from
Dec 28, 2022
Merged

Cleanup product task experiment #35950

chihsuan merged 8 commits into from
Dec 28, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Dec 13, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/team-ghidorah/issues/131.

  • Remove previous product & card layout code 9619d4e
  • Rename ./experimental-products -> ./products a77340c
  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to onboarding wizard's Business Features step
  2. Set "Currently selling elsewhere" to "Yes, on other platform" and save
  3. Go to WooCommerce > products task
  4. Observe the import screen is displayed
  5. Go to onboarding wizard's Business Features step
  6. Set "Currently selling elsewhere" to "No"
  7. Go to WooCommerce > products task
  8. Observe the add product stacked layout screen is displayed

import product

Screen Shot 2022-12-13 at 15 15 33

add product stacked layout

Screen Shot 2022-12-13 at 15 14 14

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 13, 2022
@chihsuan chihsuan self-assigned this Dec 13, 2022
@chihsuan chihsuan marked this pull request as ready for review December 13, 2022 07:26
@chihsuan chihsuan force-pushed the dev/clean-up-product-layout-exp-codes branch from e7cd396 to 870c2be Compare December 13, 2022 07:29
@chihsuan chihsuan requested review from a team, adrianduffell and rjchow December 13, 2022 07:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022 •
edited
Loading

Test Results Summary

Commit SHA: f332108

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 14s
E2E Tests187006019313m 31s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

rjchow
rjchow reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up! There's a little more .. stuff .. that can be removed: f637dd2

@github-actions github-actions bot added the package: @woocommerce/onboarding issues related to @woocommerce/onboarding label Dec 21, 2022
@chihsuan
Copy link
Member Author

chihsuan commented Dec 21, 2022

Thanks for cleaning up! There's a little more .. stuff .. that can be removed: f637dd2

Ah, thanks! @rjchow 🙏

I've removed the experiment code in 06ae308 / 349fa69 and also renamed experimental-import-products to import-products (61f6cfe).

@ilyasfoo ilyasfoo self-requested a review December 27, 2022 02:36
ilyasfoo
ilyasfoo approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing an extensive clean up, @chihsuan! I was contemplating to keep some of the codes in WooOnboardingTask in case if we need to experiment another task in the future, but then it wasn't the most optimal solution either with polling. Perhaps we could figure out a better way to implement in the future.

I also tested tracks and importing sample products, LGTM! 🚢 🚀

@chihsuan chihsuan requested a review from rjchow December 27, 2022 10:38
rjchow
rjchow approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you!

@chihsuan chihsuan merged commit 9f0d718 into trunk Dec 28, 2022
@chihsuan chihsuan deleted the dev/clean-up-product-layout-exp-codes branch December 28, 2022 08:08
@github-actions github-actions bot added this to the 7.4.0 milestone Dec 28, 2022
joelclimbsthings pushed a commit that referenced this pull request Jan 6, 2023
@chihsuan @joelclimbsthings
Cleanup product task experiment (#35950)
2219ec3 
* Cleanup product task experiment

* Rename experimental-products -> products

* Add changelog

* Clean up product task experiment in woo/onboarding

Remove product variant

* Rename experimental-import-products -> import-products

* Clean up OnboardingTasks.php

* Add changelog

* Remove experimental-products-task feature flag
@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianduffell adrianduffell Awaiting requested review from adrianduffell

2 more reviewers

@ilyasfoo ilyasfoo ilyasfoo approved these changes

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

package: @woocommerce/onboarding issues related to @woocommerce/onboarding plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chihsuan @ilyasfoo @rjchow