Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Dec 13, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #35505 #34780.

Fixes Dismiss" button overlaps with task list "Add (Paid Theme) to my store"

Before

Screen Shot 2022-12-13 at 14 26 35

After

Screen Shot 2022-12-13 at 14 25 55

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Complete the OBW till Themes tab.
  2. Select any Paid theme and complete the OBW.
  3. Go to Woocommerce > Home.
  4. Select ellipsis menu of "Add (Paid Theme) to my store" task from Set up tasklist.
  5. Observe that, "Dismiss" button is shown properly with task list "Add (Paid Theme) to my store".

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan marked this pull request as ready for review December 13, 2022 06:24
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 13, 2022
@chihsuan chihsuan self-assigned this Dec 13, 2022
@chihsuan chihsuan changed the title Fix/35505 ellipsis dropdown is hidden Fix ellipsis dropdown is hidden in task list Dec 13, 2022
@chihsuan chihsuan requested review from a team, ilyasfoo and moon0326 December 13, 2022 06:27
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 375d31d

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 54s
E2E Tests187006019316m 25s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that fix works with no side effects that I noticed! Wonder why the overflow was there

@ilyasfoo
Copy link
Contributor

I think 1 reviewer is sufficient for this PR 🙏

@chihsuan
Copy link
Member Author

Wonder why the overflow was there

Thanks @rjchow. Yeah, I was wondering about that as well and didn't see anything broken with this change.

@chihsuan chihsuan merged commit 679e875 into trunk Dec 14, 2022
@chihsuan chihsuan deleted the fix/35505-ellipsis-dropdown-is-hidden branch December 14, 2022 05:53
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 14, 2022
samueljseay pushed a commit that referenced this pull request Dec 15, 2022
* Fix the ellipsis dropdown menu is mostly hidden within the task list

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GlobalStep] "Dismiss" button overlaps with task list "Add (Paid Theme) to my store" after clicking ellipsis menu on "Woocommerce > Home" page.

4 participants