Skip to content

Fix wcpay benefits UI padding #35946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 2 commits into from
Dec 15, 2022
Merged

Fix wcpay benefits UI padding #35946

chihsuan merged 2 commits into from
Dec 15, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Dec 13, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #35704.

This PR fixes the padding bug caused by WP 6.1.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to OBW
  2. Continue with a WCPay eligible country such as US
  3. Uncheck WCPay in the business details step
  4. Complete OBW
  5. Go to WooCommerce > Home > Set up payments task
  6. Observe that the benefit UI is displayed properly.

before:

Screen Shot 2022-12-13 at 11 32 12

after:

Screen Shot 2022-12-13 at 11 32 21

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan marked this pull request as ready for review December 13, 2022 03:37
@chihsuan chihsuan self-assigned this Dec 13, 2022
@chihsuan chihsuan requested review from a team, adrianduffell and rjchow December 13, 2022 03:37
@github-actions github-actions bot added the package: @woocommerce/onboarding issues related to @woocommerce/onboarding label Dec 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Test Results Summary

Commit SHA: 51f90ee

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 54s
E2E Tests187006019312m 50s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

adrianduffell
adrianduffell approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested great, thanks @chihsuan!

The change is simple enough, I think we can merge with one reviewer.

@chihsuan chihsuan merged commit 736395b into trunk Dec 15, 2022
@chihsuan chihsuan deleted the fix/35704-wcpay-benefit-padding branch December 15, 2022 11:47
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 15, 2022
samueljseay pushed a commit that referenced this pull request Dec 15, 2022
@chihsuan @samueljseay
Fix wcpay benefits UI padding (#35946)
9cc47cb 
* Fix wcpay benefits padding

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjchow rjchow Awaiting requested review from rjchow

1 more reviewer

@adrianduffell adrianduffell adrianduffell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

package: @woocommerce/onboarding issues related to @woocommerce/onboarding

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

Too much padding between wcpay benefit items

3 participants

@chihsuan @adrianduffell