Skip to content

Fix RegExp used to filter the country list dropdown on the store details step #35942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moon0326 merged 2 commits into from
Dec 13, 2022
Merged

Fix RegExp used to filter the country list dropdown on the store details step #35942

moon0326 merged 2 commits into from
Dec 13, 2022

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Dec 12, 2022

All Submissions:

Closes #35941

How to test the changes in this Pull Request:

  1. Checkout this branch and build the assets.
  2. Start OBW
  3. On the store details step, try to search for a country.
  4. Confirm the filtered result doesn't contain any relevant countries.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326 moon0326 requested review from a team, chihsuan and rjchow December 12, 2022 22:21
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022 •
edited
Loading

Test Results Summary

Commit SHA: 9844732

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests187006019313m 18s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

chihsuan
chihsuan approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this! @moon0326 👍

@moon0326 moon0326 merged commit 1311835 into trunk Dec 13, 2022
@moon0326 moon0326 deleted the fix/35941-fix-country-dropdown-filter-results branch December 13, 2022 02:48
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 13, 2022
samueljseay pushed a commit that referenced this pull request Dec 15, 2022
@samueljseay
Fix RegExp used to filter the country list dropdown on the store deta…
53b417f 
…ils step (#35942)

* Add custom regexp for the country dropdown search

* Add changelog
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chihsuan chihsuan chihsuan approved these changes

@rjchow rjchow Awaiting requested review from rjchow

Assignees

No one assigned

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

OBW - Country dropdown returns incorrect filtered result

3 participants

@moon0326 @chihsuan