Skip to content

Fix wrong query param in onboarding product api call #35926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chihsuan merged 3 commits into from
Dec 14, 2022
Merged

Fix wrong query param in onboarding product api call #35926

chihsuan merged 3 commits into from
Dec 14, 2022

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Dec 12, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #35846.

I mistakenly added the user-agent to the query in https://github.com/woocommerce/woocommerce/pull/34461/files#diff-c4dd3352cdd52db33131d66f0f88be1de6ff47c00b9e5951462da52f5da8b0d5L85-L86. The user-agent needs to be passed as args to wp_remote_get instead. It's causing a performance issue on WCCOM.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Go to OBW
  2. Go to the Product types step
  3. Click on an info icon (i)
  4. Observe that tooltip shows contents properly.

Screen Shot 2022-12-12 at 16 42 01

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan self-assigned this Dec 12, 2022
@chihsuan chihsuan marked this pull request as ready for review December 12, 2022 08:42
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Dec 12, 2022
@chihsuan
Copy link
Member Author

chihsuan commented Dec 12, 2022

This is a small fix. I think one reviewer should be sufficient.

@chihsuan chihsuan requested review from a team, adrianduffell and rjchow December 12, 2022 08:44
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022

Test Results Summary

Commit SHA: 8071890

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 1s
E2E Tests187006019316m 4s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

rjchow
rjchow approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@chihsuan chihsuan merged commit 9070cff into trunk Dec 14, 2022
@chihsuan chihsuan deleted the fix/onboarding-api-query branch December 14, 2022 05:34
@github-actions github-actions bot added this to the 7.3.0 milestone Dec 14, 2022
samueljseay pushed a commit that referenced this pull request Dec 15, 2022
@chihsuan @samueljseay
Fix wrong query param in onboarding product api call (#35926)
e037f8c 
* Fix wrong query param in onboarding product api call

* Add changelog

* Fix lint
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianduffell adrianduffell Awaiting requested review from adrianduffell

1 more reviewer

@rjchow rjchow rjchow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chihsuan chihsuan

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

7.3.0

Development

Successfully merging this pull request may close these issues.

Wrong query params of wccom-extensions API call in get_product_data method

3 participants

@chihsuan @rjchow